Movatterモバイル変換

Skip to content

postgrespro/postgresPublic

forked frompostgres/postgres

NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitfa2cfb9

tglsfdc

committed

printf("%lf") is not portable, so omit the "l".

The "l" (ell) width spec means something in the corresponding scanf usage,but not here. While modern POSIX says that applying "l" to "f" and otherfloating format specs is a no-op, SUSv2 says it's undefined. Buildfarmexperience says that some old compilers emit warnings about it, and atleast one old stdio implementation (mingw's "ANSI" option) actuallyproduces wrong answers and/or crashes.Discussion:https://postgr.es/m/21670.1526769114@sss.pgh.pa.usDiscussion:https://postgr.es/m/c085e1da-0d64-1c15-242d-c921f32e0d5c@dunslane.net

1 parenta5be529 commitfa2cfb9Copy full SHA for fa2cfb9

File tree

7 files changed

+7

-7

lines changed

doc/src/sgml
- ecpg.sgml
src/interfaces/ecpg/test
- compat_informix
  - sqlda.pgc
- expected
- preproc
  - outofscope.pgc
- sql
  - sqlda.pgc

7 files changed

+7

-7

lines changed

`‎doc/src/sgml/ecpg.sgml`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1678,7 +1678,7 @@ while (1)`
`1678`	`1678`	`<para>`
`1679`	`1679`	`Here is an example using the data type <type>complex</type> from`
`1680`	`1680`	`the example in <xref linkend="xtypes">. The external string`
`1681`		`- representation of that type is <literal>(%lf,%lf)</literal>,`
	`1681`	`+ representation of that type is <literal>(%f,%f)</literal>,`
`1682`	`1682`	`which is defined in the`
`1683`	`1683`	`functions <function>complex_in()</function>`
`1684`	`1684`	`and <function>complex_out()</function> functions`

`‎src/interfaces/ecpg/test/compat_informix/sqlda.pgc`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ dump_sqlda(sqlda_t *sqlda)`
`37`	`37`	`printf("name sqlda descriptor: '%s' value %d\n", sqlda->sqlvar[i].sqlname, (int )sqlda->sqlvar[i].sqldata);`
`38`	`38`	`break;`
`39`	`39`	`case SQLFLOAT:`
`40`		`-printf("name sqlda descriptor: '%s' value %lf\n", sqlda->sqlvar[i].sqlname, (double )sqlda->sqlvar[i].sqldata);`
	`40`	`+printf("name sqlda descriptor: '%s' value %f\n", sqlda->sqlvar[i].sqlname, (double )sqlda->sqlvar[i].sqldata);`
`41`	`41`	`break;`
`42`	`42`	`case SQLDECIMAL:`
`43`	`43`	`{`

`‎src/interfaces/ecpg/test/expected/compat_informix-sqlda.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ dump_sqlda(sqlda_t *sqlda)`
`142`	`142`	`printf("name sqlda descriptor: '%s' value %d\n",sqlda->sqlvar[i].sqlname,(int)sqlda->sqlvar[i].sqldata);`
`143`	`143`	`break;`
`144`	`144`	`caseSQLFLOAT:`
`145`		`-printf("name sqlda descriptor: '%s' value %lf\n",sqlda->sqlvar[i].sqlname,(double)sqlda->sqlvar[i].sqldata);`
	`145`	`+printf("name sqlda descriptor: '%s' value %f\n",sqlda->sqlvar[i].sqlname,(double)sqlda->sqlvar[i].sqldata);`
`146`	`146`	`break;`
`147`	`147`	`caseSQLDECIMAL:`
`148`	`148`	`{`

`‎src/interfaces/ecpg/test/expected/preproc-outofscope.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ if (sqlca.sqlcode < 0) exit (1);}`
`337`	`337`	`get_record1();`
`338`	`338`	`if (sqlca.sqlcode==ECPG_NOT_FOUND)`
`339`	`339`	`break;`
`340`		`-printf("id=%d%s t='%s'%s d1=%lf%s d2=%lf%s c = '%s'%s\n",`
	`340`	`+printf("id=%d%s t='%s'%s d1=%f%s d2=%f%s c = '%s'%s\n",`
`341`	`341`	`myvar->id,mynullvar->id ?" (NULL)" :"",`
`342`	`342`	`myvar->t,mynullvar->t ?" (NULL)" :"",`
`343`	`343`	`myvar->d1,mynullvar->d1 ?" (NULL)" :"",`

`‎src/interfaces/ecpg/test/expected/sql-sqlda.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ dump_sqlda(sqlda_t *sqlda)`
`158`	`158`	`break;`
`159`	`159`	`#endif`
`160`	`160`	`caseECPGt_double:`
`161`		`-printf("name sqlda descriptor: '%s' value %lf\n",sqlda->sqlvar[i].sqlname.data,(double)sqlda->sqlvar[i].sqldata);`
	`161`	`+printf("name sqlda descriptor: '%s' value %f\n",sqlda->sqlvar[i].sqlname.data,(double)sqlda->sqlvar[i].sqldata);`
`162`	`162`	`break;`
`163`	`163`	`caseECPGt_numeric:`
`164`	`164`	`{`

`‎src/interfaces/ecpg/test/preproc/outofscope.pgc`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ main (void)`
`101`	`101`	`get_record1();`
`102`	`102`	`if (sqlca.sqlcode == ECPG_NOT_FOUND)`
`103`	`103`	`break;`
`104`		`-printf("id=%d%s t='%s'%s d1=%lf%s d2=%lf%s c = '%s'%s\n",`
	`104`	`+printf("id=%d%s t='%s'%s d1=%f%s d2=%f%s c = '%s'%s\n",`
`105`	`105`	`myvar->id, mynullvar->id ? " (NULL)" : "",`
`106`	`106`	`myvar->t, mynullvar->t ? " (NULL)" : "",`
`107`	`107`	`myvar->d1, mynullvar->d1 ? " (NULL)" : "",`

`‎src/interfaces/ecpg/test/sql/sqlda.pgc`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ dump_sqlda(sqlda_t *sqlda)`
`45`	`45`	`break;`
`46`	`46`	`#endif`
`47`	`47`	`case ECPGt_double:`
`48`		`-printf("name sqlda descriptor: '%s' value %lf\n", sqlda->sqlvar[i].sqlname.data, (double )sqlda->sqlvar[i].sqldata);`
	`48`	`+printf("name sqlda descriptor: '%s' value %f\n", sqlda->sqlvar[i].sqlname.data, (double )sqlda->sqlvar[i].sqldata);`
`49`	`49`	`break;`
`50`	`50`	`case ECPGt_numeric:`
`51`	`51`	`{`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp