NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf9f31aa

committed

Make parseNodeString() C idiom compatible with Visual Studio 2015.

Between v15 and now, this function's "else if" chain grew from 252 linesto 592 lines, exceeding a compiler limit that manifests as "fatal errorC1026: parser stack overflow, program too complex (compiling source filesrc/backend/nodes/readfuncs.c)". Use "if (...) return ...;" instead.Reviewed by Tom Lane, Peter Eisentraut and Michael Paquier. Not allreviewers endorse this.Discussion:https://postgr.es/m/20230607185458.GA1334487@rfd.leadboat.com

1 parent4327f6c commitf9f31aaCopy full SHA for f9f31aa

File tree

2 files changed

-12

lines changed

src/backend/nodes
- gen_node_support.pl
- readfuncs.c

2 files changed

-12

lines changed

`‎src/backend/nodes/gen_node_support.pl`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -924,9 +924,9 @@ sub elem`
`924`	`924`	`."\t\t\t\t_out${n}(str, obj);\n"`
`925`	`925`	`."\t\t\t\tbreak;\n";`
`926`	`926`
`927`		`-print$rfs"\telse if (MATCH(\"$N\","`
	`927`	`+print$rfs"\tif (MATCH(\"$N\","`
`928`	`928`	`.length($N) ."))\n"`
`929`		`- ."\t\treturn_value = _read${n}();\n"`
	`929`	`+ ."\t\treturn (Node *) _read${n}();\n"`
`930`	`930`	`unless$no_read;`
`931`	`931`
`932`	`932`	`nextif elem$n,@custom_read_write;`

`‎src/backend/nodes/readfuncs.c`

Lines changed: 2 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -697,8 +697,6 @@ _readExtensibleNode(void)`
`697`	`697`	`Node*`
`698`	`698`	`parseNodeString(void)`
`699`	`699`	`{`
`700`		`-void*return_value;`
`701`		`-`
`702`	`700`	`READ_TEMP_LOCALS();`
`703`	`701`
`704`	`702`	`/* Guard against stack overflow due to overly complex expressions */`
`@@ -709,16 +707,10 @@ parseNodeString(void)`
`709`	`707`	`#defineMATCH(tokname,namelen) \`
`710`	`708`	`(length == namelen && memcmp(token, tokname, namelen) == 0)`
`711`	`709`
`712`		`-if (false)`
`713`		`-;`
`714`	`710`	`#include"readfuncs.switch.c"`
`715`		`-else`
`716`		`-{`
`717`		`-elog(ERROR,"badly formatted node string \"%.32s\"...",token);`
`718`		`-return_value=NULL;/* keep compiler quiet */`
`719`		`-}`
`720`	`711`
`721`		`-return (Node*)return_value;`
	`712`	`+elog(ERROR,"badly formatted node string \"%.32s\"...",token);`
	`713`	`+returnNULL;/* keep compiler quiet */`
`722`	`714`	`}`
`723`	`715`
`724`	`716`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf9f31aa

File tree

2 files changed

2 files changed

`‎src/backend/nodes/gen_node_support.pl`

`‎src/backend/nodes/readfuncs.c`

0 commit comments