Commitf9bb944

committed

pg_test_fsync: add C comment about direct I/O and write size failure

Report from Marti Raudsepp

1 parent6f2aead commitf9bb944Copy full SHA for f9bb944

File tree

-0

lines changed

-0

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -369,6 +369,12 @@ test_sync(int writes_per_op)`
`369`	`369`	`{`
`370`	`370`	`for (writes=0;writes<writes_per_op;writes++)`
`371`	`371`	`if (write(tmpfile,buf,XLOG_BLCKSZ)!=XLOG_BLCKSZ)`
	`372`	`+/*`
	`373`	`+ * This can generate write failures if the filesystem`
	`374`	`+ * has a large block size, e.g. 4k, and there is no`
	`375`	`+ * support for O_DIRECT writes smaller than the`
	`376`	`+ * file system block size, e.g. XFS.`
	`377`	`+ */`
`372`	`378`	`die("write failed");`
`373`	`379`	`if (lseek(tmpfile,0,SEEK_SET)==-1)`
`374`	`380`	`die("seek failed");`

Comments

(0)