NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf97f0c9

committed

Adjust _bt_insertonpg() comments

Remove an obsolete reference to the 'afteritem' argument, which wasremoved by commitbc29293. Add a comment that clarifies how_bt_insertonpg() indirectly handles the insertion of high key items.Author: Peter Geoghegan

1 parent3d92796 commitf97f0c9Copy full SHA for f97f0c9

File tree

1 file changed

-6

lines changed

src/backend/access/nbtree
- nbtinsert.c

1 file changed

-6

lines changed

`‎src/backend/access/nbtree/nbtinsert.c`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -817,18 +817,18 @@ _bt_findinsertloc(Relation rel,`
`817`	`817`	`*insertion, and the buffer must be pinned and write-locked. On return,`
`818`	`818`	`*we will have dropped both the pin and the lock on the buffer.`
`819`	`819`	`*`
`820`		`- *When inserting to a non-leaf page, 'cbuf' is the left-sibling of the`
`821`		`- *page we're inserting the downlink for. This function will clear the`
	`820`	`+ *This routine only performs retail tuple insertions. 'itup' should`
	`821`	`+ *always be either a non-highkey leaf item, or a downlink (new high`
	`822`	`+ *key items are created indirectly, when a page is split). When`
	`823`	`+ *inserting to a non-leaf page, 'cbuf' is the left-sibling of the page`
	`824`	`+ *we're inserting the downlink for. This function will clear the`
`822`	`825`	`*INCOMPLETE_SPLIT flag on it, and release the buffer.`
`823`	`826`	`*`
`824`	`827`	`*The locking interactions in this code are critical. You should`
`825`	`828`	`*grok Lehman and Yao's paper before making any changes. In addition,`
`826`	`829`	`*you need to understand how we disambiguate duplicate keys in this`
`827`	`830`	`*implementation, in order to be able to find our location using`
`828`		`- *L&Y "move right" operations. Since we may insert duplicate user`
`829`		`- *keys, and since these dups may propagate up the tree, we use the`
`830`		`- *'afteritem' parameter to position ourselves correctly for the`
`831`		`- *insertion on internal pages.`
	`831`	`+ *L&Y "move right" operations.`
`832`	`832`	`*----------`
`833`	`833`	`*/`
`834`	`834`	`staticvoid`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf97f0c9

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtinsert.c`

0 commit comments