forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitf8d03ea
committed
Remove unnecessary unbind in LDAP search+bind mode
Comments in src/backend/libpq/auth.c say: (after successfully findingthe final DN to check the user-supplied password against)/* Unbind and disconnect from the LDAP server */and later/* * Need to re-initialize the LDAP connection, so that we can bind to * it with a different username. */But the protocol actually permits multiple subsequent authentications("binds") over a single connection.So, it seems like the whole connection re-initialization thing wasjust a confusion and can be safely removed, thus saving quite a fewnetwork round-trips, especially for the case of ldaps/starttls.Author: Anatoly Zaretsky <anatoly.zaretsky@gmail.com>Discussion:https://www.postgresql.org/message-id/flat/CALbq6kmJ-1+58df4B51ctPfTOSyPbY8Qi2=ct8oR=i4TamkUoQ@mail.gmail.com1 parent89333db commitf8d03ea
2 files changed
+3
-28
lines changedLines changed: 3 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1775 | 1775 |
| |
1776 | 1776 |
| |
1777 | 1777 |
| |
1778 |
| - | |
| 1778 | + | |
1779 | 1779 |
| |
1780 | 1780 |
| |
1781 | 1781 |
| |
1782 | 1782 |
| |
1783 | 1783 |
| |
1784 |
| - | |
| 1784 | + | |
1785 | 1785 |
| |
1786 | 1786 |
| |
1787 | 1787 |
| |
| |||
2008 | 2008 |
| |
2009 | 2009 |
| |
2010 | 2010 |
| |
2011 |
| - | |
| 2011 | + | |
2012 | 2012 |
| |
2013 | 2013 |
| |
2014 | 2014 |
| |
|
Lines changed: 0 additions & 25 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2611 | 2611 |
| |
2612 | 2612 |
| |
2613 | 2613 |
| |
2614 |
| - | |
2615 |
| - | |
2616 |
| - | |
2617 |
| - | |
2618 |
| - | |
2619 |
| - | |
2620 |
| - | |
2621 |
| - | |
2622 |
| - | |
2623 |
| - | |
2624 |
| - | |
2625 |
| - | |
2626 |
| - | |
2627 |
| - | |
2628 |
| - | |
2629 |
| - | |
2630 |
| - | |
2631 |
| - | |
2632 |
| - | |
2633 |
| - | |
2634 |
| - | |
2635 |
| - | |
2636 |
| - | |
2637 |
| - | |
2638 |
| - | |
2639 | 2614 |
| |
2640 | 2615 |
| |
2641 | 2616 |
| |
|
0 commit comments
Comments
(0)