NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf8a4dd2

committed

Fix unsafe coding in ReorderBufferCommit().

"iterstate" must be marked volatile since it's changed inside the PG_TRYblock and then used in the PG_CATCH stanza. Noted by Mark Wilding ofSalesforce. (We really need to see if we can't get the C compiler to warnabout this.)Also, reset iterstate to NULL after the mainline ReorderBufferIterTXNFinishcall, to ensure the PG_CATCH block doesn't try to do that a second time.

1 parent586dd5d commitf8a4dd2Copy full SHA for f8a4dd2

File tree

1 file changed

-3

lines changed

src/backend/replication/logical
- reorderbuffer.c

1 file changed

-3

lines changed

`‎src/backend/replication/logical/reorderbuffer.c`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1258,7 +1258,7 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,`
`1258`	`1258`	`TimestampTzcommit_time)`
`1259`	`1259`	`{`
`1260`	`1260`	`ReorderBufferTXN*txn;`
`1261`		`-ReorderBufferIterTXNState*iterstate=NULL;`
	`1261`	`+ReorderBufferIterTXNState*volatileiterstate=NULL;`
`1262`	`1262`	`ReorderBufferChange*change;`
`1263`	`1263`
`1264`	`1264`	`volatileCommandIdcommand_id=FirstCommandId;`
`@@ -1303,7 +1303,6 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,`
`1303`	`1303`
`1304`	`1304`	`PG_TRY();`
`1305`	`1305`	`{`
`1306`		`-`
`1307`	`1306`	`/*`
`1308`	`1307`	`* Decoding needs access to syscaches et al., which in turn use`
`1309`	`1308`	`* heavyweight locks and such. Thus we need to have enough state`
`@@ -1472,7 +1471,9 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,`
`1472`	`1471`	`}`
`1473`	`1472`	`}`
`1474`	`1473`
	`1474`	`+/* clean up the iterator */`
`1475`	`1475`	`ReorderBufferIterTXNFinish(rb,iterstate);`
	`1476`	`+iterstate=NULL;`
`1476`	`1477`
`1477`	`1478`	`/* call commit callback */`
`1478`	`1479`	`rb->commit(rb,txn,commit_lsn);`
`@@ -1639,7 +1640,7 @@ ReorderBufferForget(ReorderBuffer *rb, TransactionId xid, XLogRecPtr lsn)`
`1639`	`1640`	`*/`
`1640`	`1641`	`if (txn->base_snapshot!=NULL&&txn->ninvalidations>0)`
`1641`	`1642`	`{`
`1642`		`-booluse_subtxn=IsTransactionOrTransactionBlock();`
	`1643`	`+booluse_subtxn=IsTransactionOrTransactionBlock();`
`1643`	`1644`
`1644`	`1645`	`if (use_subtxn)`
`1645`	`1646`	`BeginInternalSubTransaction("replay");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf8a4dd2

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/reorderbuffer.c`

0 commit comments