NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf854dae

committed

Improve comment about query_id_enabled in queryjumblefuncs.c

The comment was inexact because query_id_enabled will not be switched to"true" even if compute_query_id is "on", unless a module requests forit.While on it, this adds a comment to mention that IsQueryIdEnabled()should be used to check if query ID computation is enabled or not.Author: Yugo NagataReviewed-by: Julien RouhaudDiscussion:https://postgr.es/m/20240209153823.e29a68cadb14225f1362a2cf@sraoss.co.jp

1 parent5ebc9c9 commitf854daeCopy full SHA for f854dae

File tree

1 file changed

-1

lines changed

src/backend/nodes
- queryjumblefuncs.c

1 file changed

-1

lines changed

`‎src/backend/nodes/queryjumblefuncs.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,13 @@`
`42`	`42`	`/* GUC parameters */`
`43`	`43`	`intcompute_query_id=COMPUTE_QUERY_ID_AUTO;`
`44`	`44`
`45`		`-/* True when compute_query_id is ON, or AUTO and a module requests them */`
	`45`	`+/*`
	`46`	`+ * True when compute_query_id is ON or AUTO, and a module requests them.`
	`47`	`+ *`
	`48`	`+ * Note that IsQueryIdEnabled() should be used instead of checking`
	`49`	`+ * query_id_enabled or compute_query_id directly when we want to know`
	`50`	`+ * whether query identifiers are computed in the core or not.`
	`51`	`+ */`
`46`	`52`	`boolquery_id_enabled= false;`
`47`	`53`
`48`	`54`	`staticvoidAppendJumble(JumbleState*jstate,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf854dae

File tree

1 file changed

1 file changed

`‎src/backend/nodes/queryjumblefuncs.c`

0 commit comments