Commitf7d7ac2

committed

Fix overly generic name in with.sql test.

Avoid the name "test". In the 10 branch, this could clash withalter_table.sql, as seen in the build farm. That other instance wasalready renamed in later branches by commit2cf8c7a, but it's good tofuture-proof the name here too.Back-patch to 10.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://postgr.es/m/CA%2BhUKGJf4RAXUyAYVUcQawcptX%3DnhEco3SYpuPK5cCbA-F1eLA%40mail.gmail.com

1 parent2ff2099 commitf7d7ac2Copy full SHA for f7d7ac2

File tree

+13

-13

lines changed

+13

-13

lines changed

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -3118,19 +3118,19 @@ with ordinality as (select 1 as x) select * from ordinality;`
`3118`	`3118`	`(1 row)`
`3119`	`3119`
`3120`	`3120`	`-- check sane response to attempt to modify CTE relation`
`3121`		`-WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`3122`		`-ERROR: relation "test" does not exist`
`3123`		`-LINE 1: WITHtest AS (SELECT 42) INSERT INTOtest VALUES (1);`
`3124`		`- ^`
	`3121`	`+WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (1);`
	`3122`	`+ERROR: relation "with_test" does not exist`
	`3123`	`+LINE 1: WITHwith_test AS (SELECT 42) INSERT INTOwith_test VALUES (...`
	`3124`	`+^`
`3125`	`3125`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`3126`	`3126`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`3127`	`3127`	`-- statements)`
`3128`		`-create temp tabletest (i int);`
`3129`		`-withtest as (select 42) insert intotest select * fromtest;`
`3130`		`-select * fromtest;`
	`3128`	`+create temp tablewith_test (i int);`
	`3129`	`+withwith_test as (select 42) insert intowith_test select * fromwith_test;`
	`3130`	`+select * fromwith_test;`
`3131`	`3131`	`i`
`3132`	`3132`	`----`
`3133`	`3133`	`42`
`3134`	`3134`	`(1 row)`
`3135`	`3135`
`3136`		`-drop tabletest;`
	`3136`	`+drop tablewith_test;`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1451,12 +1451,12 @@ create table foo (with ordinality); -- fail, WITH is a reserved word`
`1451`	`1451`	`with ordinalityas (select1as x)select*from ordinality;`
`1452`	`1452`
`1453`	`1453`	`-- check sane response to attempt to modify CTE relation`
`1454`		`-WITHtestAS (SELECT42)INSERT INTOtestVALUES (1);`
	`1454`	`+WITHwith_testAS (SELECT42)INSERT INTOwith_testVALUES (1);`
`1455`	`1455`
`1456`	`1456`	`-- check response to attempt to modify table with same name as a CTE (perhaps`
`1457`	`1457`	`-- surprisingly it works, because CTEs don't hide tables from data-modifying`
`1458`	`1458`	`-- statements)`
`1459`		`-create temp tabletest (iint);`
`1460`		`-withtestas (select42)insert intotestselect*fromtest;`
`1461`		`-select*fromtest;`
`1462`		`-droptabletest;`
	`1459`	`+create temp tablewith_test (iint);`
	`1460`	`+withwith_testas (select42)insert intowith_testselect*fromwith_test;`
	`1461`	`+select*fromwith_test;`
	`1462`	`+droptablewith_test;`

Comments

(0)