Commitf7bd0a3

committed

Prevent CRLF conversion of inputs in json_parser test module

Do this by opening the file in PG_BINARY_R mode. This prevents us fromgetting wrong byte count from stat().Per complaint from Andres FreundDiscussion:https://postgr.es/m/20240707052030.r77hbdkid3mwksop@awork3.anarazel.deBackpatch to rlease 17 where this code was introduced

1 parent896cd26 commitf7bd0a3Copy full SHA for f7bd0a3

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ main(int argc, char **argv)`
`124`	`124`	`makeJsonLexContextIncremental(&lex,PG_UTF8,need_strings);`
`125`	`125`	`initStringInfo(&json);`
`126`	`126`
`127`		`-if ((json_file=fopen(testfile,"r"))==NULL)`
	`127`	`+if ((json_file=fopen(testfile,PG_BINARY_R))==NULL)`
`128`	`128`	`pg_fatal("error opening input: %m");`
`129`	`129`
`130`	`130`	`if (fstat(fileno(json_file),&statbuf)!=0)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ main(int argc, char **argv)`
`55`	`55`
`56`	`56`	`sscanf(argv[1],"%d",&iter);`
`57`	`57`
`58`		`-if ((json_file=fopen(argv[2],"r"))==NULL)`
	`58`	`+if ((json_file=fopen(argv[2],PG_BINARY_R))==NULL)`
`59`	`59`	`pg_fatal("Could not open input file '%s': %m",argv[2]);`
`60`	`60`
`61`	`61`	`while ((n_read=fread(buff,1,6000,json_file))>0)`

Comments

(0)