Commitf7bb7f0

committed

Allow background workers to connect to no particular database.

The documentation claims that this is supported, but it didn'tactually work. Fix that.Reported by Pavel Stehule; patch by me.

1 parent5d1ff6b commitf7bb7f0Copy full SHA for f7bb7f0

File tree

+13

-1

lines changed

+13

-1

lines changed

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -827,7 +827,7 @@ InitPostgres(const char in_dbname, Oid dboid, const char username,`
`827`	`827`	`/* take database name from the caller, just for paranoia */`
`828`	`828`	`strlcpy(dbname,in_dbname,sizeof(dbname));`
`829`	`829`	`}`
`830`		`-else`
	`830`	`+elseif (OidIsValid(dboid))`
`831`	`831`	`{`
`832`	`832`	`/* caller specified database by OID */`
`833`	`833`	`HeapTupletuple;`
`@@ -847,6 +847,18 @@ InitPostgres(const char in_dbname, Oid dboid, const char username,`
`847`	`847`	`if (out_dbname)`
`848`	`848`	`strcpy(out_dbname,dbname);`
`849`	`849`	`}`
	`850`	`+else`
	`851`	`+{`
	`852`	`+/*`
	`853`	`+ * If this is a background worker not bound to any particular`
	`854`	`+ * database, we're done now. Everything that follows only makes`
	`855`	`+ * sense if we are bound to a specific database. We do need to`
	`856`	`+ * close the transaction we started before returning.`
	`857`	`+ */`
	`858`	`+if (!bootstrap)`
	`859`	`+CommitTransactionCommand();`
	`860`	`+return;`
	`861`	`+}`
`850`	`862`
`851`	`863`	`/*`
`852`	`864`	`* Now, take a writer's lock on the database we are trying to connect to.`

Comments

(0)