Commitf7ab71b

committed

Fix typo and comments related to the recent no-wait lock improvements

The argument of dontWait at the top of ProcSleep() was documentedbackwards, and there was a typo in lock.c.Thinkos in2346df6.Author: Will MortensenReviewed-by: Jingxian Li, Michael PaquierDiscussion:https://postgr.es/m/CAMpnoC5f+eiS7tdy8PUpd_LacSTVT-pYpVooKfjHRQQmkHPZ2g@mail.gmail.com

1 parentdd087e1 commitf7ab71bCopy full SHA for f7ab71b

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1060,7 +1060,7 @@ LockAcquireExtended(const LOCKTAG *locktag,`
`1060`	`1060`
`1061`	`1061`	`/*`
`1062`	`1062`	`* Check the proclock entry status. If dontWait = true, this is an`
`1063`		`- * expected case; otherwise, it willopen happen if something in the`
	`1063`	`+ * expected case; otherwise, it willonly happen if something in the`
`1064`	`1064`	`* ipc communication doesn't work correctly.`
`1065`	`1065`	`*/`
`1066`	`1066`	`if (!(proclock->holdMask&LOCKBIT_ON(lockmode)))`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1054,8 +1054,8 @@ AuxiliaryPidGetProc(int pid)`
`1054`	`1054`	`* at exit.`
`1055`	`1055`	`*`
`1056`	`1056`	`* Result: PROC_WAIT_STATUS_OK if we acquired the lock, PROC_WAIT_STATUS_ERROR`
`1057`		`- * if not (if dontWait = true,this is a deadlock; if dontWait = false, we`
`1058`		`- *would have had to wait).`
	`1057`	`+ * if not (if dontWait = true,we would have had to wait; if dontWait = false,`
	`1058`	`+ *this is a deadlock).`
`1059`	`1059`	`*`
`1060`	`1060`	`* ASSUME: that no one will fiddle with the queue until after`
`1061`	`1061`	`*we release the partition lock.`

Comments

(0)