NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf6dba10

committed

First phase of implementing hash-based grouping/aggregation. An AGG plan

node now does its own grouping of the input rows, and has no need for apreceding GROUP node in the plan pipeline. This allows elimination ofthe misnamed tuplePerGroup option for GROUP, and actually saves more codein nodeGroup.c than it costs in nodeAgg.c, as well as being presumablyfaster. Restructure the API of query_planner so that we do not commit tousing a sorted or unsorted plan in query_planner; instead grouping_plannermakes the decision. (Right now it isn't any smarter than query_plannerwas, but that will change as soon as it has the option to select a hash-based aggregation step.) Despite all the hackery, no initdb needed sinceonly in-memory node types changed.

1 parenta8c18b9 commitf6dba10Copy full SHA for f6dba10

File tree

22 files changed

+797

-908

lines changed

src
- backend
  - commands
    - explain.c
  - executor
    - nodeAgg.c
    - nodeGroup.c
  - nodes
  - optimizer
    - README
    - geqo
      - geqo_misc.c
    - path
      - allpaths.c
    - plan
    - util
      - pathnode.c
- include
  - nodes
  - optimizer

22 files changed

+797

-908

lines changed

`‎src/backend/commands/explain.c`

Lines changed: 16 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`* Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group`
`6`	`6`	`* Portions Copyright (c) 1994-5, Regents of the University of California`
`7`	`7`	`*`
`8`		`- * $Header: /cvsroot/pgsql/src/backend/commands/explain.c,v 1.89 2002/10/14 04:26:54 momjian Exp $`
	`8`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/explain.c,v 1.90 2002/11/06 00:00:43 tgl Exp $`
`9`	`9`	`*`
`10`	`10`	`*/`
`11`	`11`
`@@ -275,7 +275,21 @@ explain_outNode(StringInfo str, Plan plan, Plan outer_plan,`
`275`	`275`	`pname="Group";`
`276`	`276`	`break;`
`277`	`277`	`caseT_Agg:`
`278`		`-pname="Aggregate";`
	`278`	`+switch (((Agg*)plan)->aggstrategy)`
	`279`	`+{`
	`280`	`+caseAGG_PLAIN:`
	`281`	`+pname="Aggregate";`
	`282`	`+break;`
	`283`	`+caseAGG_SORTED:`
	`284`	`+pname="GroupAggregate";`
	`285`	`+break;`
	`286`	`+caseAGG_HASHED:`
	`287`	`+pname="HashAggregate";`
	`288`	`+break;`
	`289`	`+default:`
	`290`	`+pname="Aggregate ???";`
	`291`	`+break;`
	`292`	`+}`
`279`	`293`	`break;`
`280`	`294`	`caseT_Unique:`
`281`	`295`	`pname="Unique";`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf6dba10

File tree

22 files changed

22 files changed

`‎src/backend/commands/explain.c`

0 commit comments