Commitf66e7ab

committed

Clarify docs on hot standby lock release

Andres Freund and Simon Riggs

1 parent8805ff6 commitf66e7abCopy full SHA for f66e7ab

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1565,6 +1565,11 @@ ProcArrayInstallImportedXmin(TransactionId xmin, TransactionId sourcexid)`
`1565`	`1565`	`* We don't worry about updating other counters, we want to keep this as`
`1566`	`1566`	`* simple as possible and leave GetSnapshotData() as the primary code for`
`1567`	`1567`	`* that bookkeeping.`
	`1568`	`+ *`
	`1569`	`+ * Note that if any transaction has overflowed its cached subtransactions`
	`1570`	`+ * then there is no real need include any subtransactions. That isn't a`
	`1571`	`+ * common enough case to worry about optimising the size of the WAL record,`
	`1572`	`+ * and we may wish to see that data for diagnostic purposes anyway.`
`1568`	`1573`	`*/`
`1569`	`1574`	`RunningTransactions`
`1570`	`1575`	`GetRunningTransactionData(void)`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -510,6 +510,10 @@ CheckRecoveryConflictDeadlock(void)`
`510`	`510`	`* RelationLockList, so we can keep track of the various entries made by`
`511`	`511`	`* the Startup process's virtual xid in the shared lock table.`
`512`	`512`	`*`
	`513`	`+ * We record the lock against the top-level xid, rather than individual`
	`514`	`+ * subtransaction xids. This means AccessExclusiveLocks held by aborted`
	`515`	`+ * subtransactions are not released as early as possible on standbys.`
	`516`	`+ *`
`513`	`517`	`* List elements use type xl_rel_lock, since the WAL record type exactly`
`514`	`518`	`* matches the information that we need to keep track of.`
`515`	`519`	`*`
`@@ -643,8 +647,8 @@ StandbyReleaseAllLocks(void)`
`643`	`647`
`644`	`648`	`/*`
`645`	`649`	`* StandbyReleaseOldLocks`
`646`		`- *Release standby locks held by XIDs that aren't running, as long`
`647`		`- *as they're not prepared transactions.`
	`650`	`+ *Release standby locks held bytop-levelXIDs that aren't running,`
	`651`	`+ *aslong asthey're not prepared transactions.`
`648`	`652`	`*/`
`649`	`653`	`void`
`650`	`654`	`StandbyReleaseOldLocks(intnxids,TransactionId*xids)`

Comments

(0)