NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf5da3d8

committed

Fix up outdated comments

The existing comments in load_relcache_init_file() were not flexiblewhen new entries were added at the end, so they ended up a bit wrong.Simplify the comments to avoid this issue.

1 parentcad5692 commitf5da3d8Copy full SHA for f5da3d8

File tree

1 file changed

-7

lines changed

src/backend/utils/cache
- relcache.c

1 file changed

-7

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -6141,7 +6141,7 @@ load_relcache_init_file(bool shared)`
`6141`	`6141`	`if (rel->rd_isnailed)`
`6142`	`6142`	`nailed_indexes++;`
`6143`	`6143`
`6144`		`-/next,read the pg_index tuple /`
	`6144`	`+/* read the pg_index tuple */`
`6145`	`6145`	`if (fread(&len,1,sizeof(len),fp)!=sizeof(len))`
`6146`	`6146`	`gotoread_failed;`
`6147`	`6147`
`@@ -6172,7 +6172,7 @@ load_relcache_init_file(bool shared)`
`6172`	`6172`	`*/`
`6173`	`6173`	`InitIndexAmRoutine(rel);`
`6174`	`6174`
`6175`		`-/next,read the vector of opfamily OIDs /`
	`6175`	`+/* read the vector of opfamily OIDs */`
`6176`	`6176`	`if (fread(&len,1,sizeof(len),fp)!=sizeof(len))`
`6177`	`6177`	`gotoread_failed;`
`6178`	`6178`
`@@ -6182,7 +6182,7 @@ load_relcache_init_file(bool shared)`
`6182`	`6182`
`6183`	`6183`	`rel->rd_opfamily=opfamily;`
`6184`	`6184`
`6185`		`-/next,read the vector of opcintype OIDs /`
	`6185`	`+/* read the vector of opcintype OIDs */`
`6186`	`6186`	`if (fread(&len,1,sizeof(len),fp)!=sizeof(len))`
`6187`	`6187`	`gotoread_failed;`
`6188`	`6188`
`@@ -6192,7 +6192,7 @@ load_relcache_init_file(bool shared)`
`6192`	`6192`
`6193`	`6193`	`rel->rd_opcintype=opcintype;`
`6194`	`6194`
`6195`		`-/next,read the vector of support procedure OIDs /`
	`6195`	`+/* read the vector of support procedure OIDs */`
`6196`	`6196`	`if (fread(&len,1,sizeof(len),fp)!=sizeof(len))`
`6197`	`6197`	`gotoread_failed;`
`6198`	`6198`	`support= (RegProcedure*)MemoryContextAlloc(indexcxt,len);`
`@@ -6201,7 +6201,7 @@ load_relcache_init_file(bool shared)`
`6201`	`6201`
`6202`	`6202`	`rel->rd_support=support;`
`6203`	`6203`
`6204`		`-/next,read the vector of collation OIDs /`
	`6204`	`+/* read the vector of collation OIDs */`
`6205`	`6205`	`if (fread(&len,1,sizeof(len),fp)!=sizeof(len))`
`6206`	`6206`	`gotoread_failed;`
`6207`	`6207`
`@@ -6211,7 +6211,7 @@ load_relcache_init_file(bool shared)`
`6211`	`6211`
`6212`	`6212`	`rel->rd_indcollation=indcollation;`
`6213`	`6213`
`6214`		`-/finally,read the vector of indoption values /`
	`6214`	`+/* read the vector of indoption values */`
`6215`	`6215`	`if (fread(&len,1,sizeof(len),fp)!=sizeof(len))`
`6216`	`6216`	`gotoread_failed;`
`6217`	`6217`
`@@ -6221,7 +6221,7 @@ load_relcache_init_file(bool shared)`
`6221`	`6221`
`6222`	`6222`	`rel->rd_indoption=indoption;`
`6223`	`6223`
`6224`		`-/finally,read the vector of opcoptions values /`
	`6224`	`+/* read the vector of opcoptions values */`
`6225`	`6225`	`rel->rd_opcoptions= (bytea**)`
`6226`	`6226`	`MemoryContextAllocZero(indexcxt,sizeof(rel->rd_opcoptions)relform->relnatts);`
`6227`	`6227`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf5da3d8

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/relcache.c`

0 commit comments