Commitf5d1886

committed

Make BufFileWrite() void.

It now either returns after it wrote all the data you gave it, or raisesan error. Not done in back-branches, because it might cause problemsfor external code.Discussion:https://postgr.es/m/CA%2BhUKGJE04G%3D8TLK0DLypT_27D9dR8F1RQgNp0jK6qR0tZGWOw%40mail.gmail.com

1 parent7897e3b commitf5d1886Copy full SHA for f5d1886

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -578,7 +578,7 @@ BufFileRead(BufFile file, void ptr, size_t size)`
`578`	`578`	`* Like fwrite() except we assume 1-byte element size and report errors via`
`579`	`579`	`* ereport().`
`580`	`580`	`*/`
`581`		`-size_t`
	`581`	`+void`
`582`	`582`	`BufFileWrite(BufFilefile,voidptr,size_tsize)`
`583`	`583`	`{`
`584`	`584`	`size_tnwritten=0;`
`@@ -617,8 +617,6 @@ BufFileWrite(BufFile file, void ptr, size_t size)`
`617`	`617`	`size-=nthistime;`
`618`	`618`	`nwritten+=nthistime;`
`619`	`619`	`}`
`620`		`-`
`621`		`-returnnwritten;`
`622`	`620`	`}`
`623`	`621`
`624`	`622`	`/*`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ typedef struct BufFile BufFile;`
`39`	`39`	`externBufFile*BufFileCreateTemp(boolinterXact);`
`40`	`40`	`externvoidBufFileClose(BufFile*file);`
`41`	`41`	`externsize_tBufFileRead(BufFilefile,voidptr,size_tsize);`
`42`		`-externsize_tBufFileWrite(BufFilefile,voidptr,size_tsize);`
	`42`	`+externvoidBufFileWrite(BufFilefile,voidptr,size_tsize);`
`43`	`43`	`externintBufFileSeek(BufFile*file,intfileno,off_toffset,intwhence);`
`44`	`44`	`externvoidBufFileTell(BufFilefile,intfileno,off_t*offset);`
`45`	`45`	`externintBufFileSeekBlock(BufFile*file,longblknum);`

Comments

(0)