NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf5d0e86

committed

Fix unstable aggregate regression test

Buildfarm member avocet has shown a plan change by switching thefinalize aggregate stage to use a GroupAggregate rather than aHashAggregate. This is consistent with autovacuum having triggered onthe table, per analysis by Alexander Lakhin.Fix this by disabling autovacuum on the table.Reported-by: Alexander LakhinDiscussion:https://postgr.es/m/d4493a28-589a-5328-fed5-250f2d7d3e2a@gmail.comBackpatch-through: 16, where this test was added.

1 parent7445f09 commitf5d0e86Copy full SHA for f5d0e86

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - aggregates.out
- sql
  - aggregates.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/aggregates.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1930,7 +1930,7 @@ select string_agg(v, decode('ee', 'hex')) from bytea_test_table;`
`1930`	`1930`
`1931`	`1931`	`drop table bytea_test_table;`
`1932`	`1932`	`-- Test parallel string_agg and array_agg`
`1933`		`-create table pagg_test (x int, y int);`
	`1933`	`+create table pagg_test (x int, y int) with (autovacuum_enabled = off);`
`1934`	`1934`	`insert into pagg_test`
`1935`	`1935`	`select (case x % 4 when 1 then null else x end), x % 10`
`1936`	`1936`	`from generate_series(1,5000) x;`

`‎src/test/regress/sql/aggregates.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -749,7 +749,7 @@ select string_agg(v, decode('ee', 'hex')) from bytea_test_table;`
`749`	`749`	`droptable bytea_test_table;`
`750`	`750`
`751`	`751`	`-- Test parallel string_agg and array_agg`
`752`		`-createtablepagg_test (xint, yint);`
	`752`	`+createtablepagg_test (xint, yint) with (autovacuum_enabled= off);`
`753`	`753`	`insert into pagg_test`
`754`	`754`	`select (case x %4 when1 thennull else x end), x %10`
`755`	`755`	`from generate_series(1,5000) x;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf5d0e86

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/aggregates.out`

`‎src/test/regress/sql/aggregates.sql`

0 commit comments