Commitf5bfb2f

petere

authored and

pull[bot]

committed

pg_upgrade: Fix some minor code issues

96ef3b8 accidentally copied a notapplicable comment from the float8_pass_by_value code to thedata_checksums code. Remove that.87d3b35 changed pg_upgrade tochecking the checksum version rather than just the Boolean presence ofchecksums, but didn't change the field type in its ControlData structfrom bool. So this would not work correctly if there ever is achecksum version larger than 1.

1 parentd50ea32 commitf5bfb2fCopy full SHA for f5bfb2f

File tree

2 files changed

-2

lines changed

src/bin/pg_upgrade
- controldata.c
- pg_upgrade.h

2 files changed

-2

lines changed

`‎src/bin/pg_upgrade/controldata.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -497,7 +497,6 @@ get_control_data(ClusterInfo *cluster, bool live_check)`
`497`	`497`	`pg_fatal("%d: controldata retrieval problem",__LINE__);`
`498`	`498`
`499`	`499`	`p++;/* remove ':' char */`
`500`		`-/* used later for contrib check */`
`501`	`500`	`cluster->controldata.data_checksum_version=str2uint(p);`
`502`	`501`	`got_data_checksum_version= true;`
`503`	`502`	`}`

`‎src/bin/pg_upgrade/pg_upgrade.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ typedef struct`
`216`	`216`	`uint32large_object;`
`217`	`217`	`booldate_is_int;`
`218`	`218`	`boolfloat8_pass_by_value;`
`219`		`-booldata_checksum_version;`
	`219`	`+uint32data_checksum_version;`
`220`	`220`	`}ControlData;`
`221`	`221`
`222`	`222`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf5bfb2f

File tree

2 files changed

2 files changed

`‎src/bin/pg_upgrade/controldata.c`

`‎src/bin/pg_upgrade/pg_upgrade.h`

0 commit comments