Commitf5a5773

committed

Allow condition variables to be used in interrupt code.

Adjust the condition variable sleep loop to work correctly when codereached by its internal CHECK_FOR_INTERRUPTS() call interacts withanother condition variable.There are no such cases currently, but a proposed patch would do this.Discussion:https://postgr.es/m/CA+hUKGLdemy2gBm80kz20GTe6hNVwoErE8KwcJk6-U56oStjtg@mail.gmail.com

1 parent814f1d8 commitf5a5773Copy full SHA for f5a5773

File tree

-2

lines changed

-2

lines changed

Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,8 +165,6 @@ ConditionVariableTimedSleep(ConditionVariable *cv, long timeout,`
`165`	`165`	`/* Reset latch before examining the state of the wait list. */`
`166`	`166`	`ResetLatch(MyLatch);`
`167`	`167`
`168`		`-CHECK_FOR_INTERRUPTS();`
`169`		`-`
`170`	`168`	`/*`
`171`	`169`	`* If this process has been taken out of the wait list, then we know`
`172`	`170`	`* that it has been signaled by ConditionVariableSignal (or`
`@@ -190,6 +188,15 @@ ConditionVariableTimedSleep(ConditionVariable *cv, long timeout,`
`190`	`188`	`}`
`191`	`189`	`SpinLockRelease(&cv->mutex);`
`192`	`190`
	`191`	`+/*`
	`192`	`+ * Check for interrupts, and return spuriously if that caused the`
	`193`	`+ * current sleep target to change (meaning that interrupt handler code`
	`194`	`+ * waited for a different condition variable).`
	`195`	`+ */`
	`196`	`+CHECK_FOR_INTERRUPTS();`
	`197`	`+if (cv!=cv_sleep_target)`
	`198`	`+done= true;`
	`199`	`+`
`193`	`200`	`/* We were signaled, so return */`
`194`	`201`	`if (done)`
`195`	`202`	`return false;`

Comments

(0)