|
11 | 11 | importorg.postgresql.core.*; |
12 | 12 |
|
13 | 13 | /** |
14 | | - * $Id: Connection.java,v 1.30 2001/10/09 20:47:35 barry Exp $ |
| 14 | + * $Id: Connection.java,v 1.31 2001/10/16 20:05:22 barry Exp $ |
15 | 15 | * |
16 | 16 | * This abstract class is used by org.postgresql.Driver to open either the JDBC1 or |
17 | 17 | * JDBC2 versions of the Connection class. |
@@ -262,6 +262,14 @@ protected void openConnection(String host, int port, Properties info, String dat |
262 | 262 | // otherwise it's hardcoded to 'SQL_ASCII'. |
263 | 263 | // If the backend doesn't know about multibyte we can't assume anything about the encoding |
264 | 264 | // used, so we denote this with 'UNKNOWN'. |
| 265 | +//Note: begining with 7.2 we should be using pg_client_encoding() which |
| 266 | +//is new in 7.2. However it isn't easy to conditionally call this new |
| 267 | +//function, since we don't yet have the information as to what server |
| 268 | +//version we are talking to. Thus we will continue to call |
| 269 | +//getdatabaseencoding() until we drop support for 7.1 and older versions |
| 270 | +//or until someone comes up with a conditional way to run one or |
| 271 | +//the other function depending on server version that doesn't require |
| 272 | +//two round trips to the server per connection |
265 | 273 |
|
266 | 274 | finalStringencodingQuery = |
267 | 275 | "case when pg_encoding_to_char(1) = 'SQL_ASCII' then 'UNKNOWN' else getdatabaseencoding() end"; |
|
