NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf4abd02

committed

Support flattening of empty-FROM subqueries and one-row VALUES tables.

We can't handle this in the general case due to limitations of theplanner's data representations; but we can allow it in many useful cases,by being careful to flatten only when we are pulling a single-row subqueryup into a FROM (or, equivalently, inner JOIN) node that will still have atleast one remaining relation child. Per discussion of an example fromKyotaro Horiguchi.

1 parentb746d0c commitf4abd02Copy full SHA for f4abd02

File tree

9 files changed

+466

-71

lines changed

src
- backend
  - nodes
    - outfuncs.c
  - optimizer
    - plan
      - planner.c
    - prep
      - prepjointree.c
- include
  - nodes
    - relation.h
  - optimizer
    - prep.h
- test/regress
  - expected
    - join.out
    - rangefuncs.out
  - sql
    - join.sql
    - rangefuncs.sql

9 files changed

+466

-71

lines changed

`‎src/backend/nodes/outfuncs.c`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1762,6 +1762,7 @@ _outPlannerInfo(StringInfo str, const PlannerInfo *node)`
`1762`	`1762`	`WRITE_BOOL_FIELD(hasInheritedTarget);`
`1763`	`1763`	`WRITE_BOOL_FIELD(hasJoinRTEs);`
`1764`	`1764`	`WRITE_BOOL_FIELD(hasLateralRTEs);`
	`1765`	`+WRITE_BOOL_FIELD(hasDeletedRTEs);`
`1765`	`1766`	`WRITE_BOOL_FIELD(hasHavingQual);`
`1766`	`1767`	`WRITE_BOOL_FIELD(hasPseudoConstantQuals);`
`1767`	`1768`	`WRITE_BOOL_FIELD(hasRecursion);`

`‎src/backend/optimizer/plan/planner.c`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -352,8 +352,7 @@ subquery_planner(PlannerGlobal glob, Query parse,`
`352`	`352`	`* Check to see if any subqueries in the jointree can be merged into this`
`353`	`353`	`* query.`
`354`	`354`	`*/`
`355`		`-parse->jointree= (FromExpr*)`
`356`		`-pull_up_subqueries(root, (Node*)parse->jointree);`
	`355`	`+pull_up_subqueries(root);`
`357`	`356`
`358`	`357`	`/*`
`359`	`358`	`* If this is a simple UNION ALL query, flatten it into an appendrel. We`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf4abd02

File tree

9 files changed

9 files changed

`‎src/backend/nodes/outfuncs.c`

`‎src/backend/optimizer/plan/planner.c`

0 commit comments