NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf44b9b6

committed

Fix rare failure in LDAP tests.

Instead of writing a query to psql's stdin, use -c. This avoids afailure where psql exits before we write, seen a few times on the buildfarm. Thanks to Tom Lane for the suggestion.Back-patch to 11, where the LDAP tests arrived.Reviewed-by: Noah Misch <noah@leadboat.com>Discussion:https://postgr.es/m/CA%2BhUKGLFmW%2BHQYPeKiwSp5sdFFHtFViCpw4Mh6yAgEx74r5-Cw%40mail.gmail.com

1 parent63e9aa6 commitf44b9b6Copy full SHA for f44b9b6

File tree

1 file changed

-1

lines changed

src/test/ldap/t
- 001_auth.pl

1 file changed

-1

lines changed

`‎src/test/ldap/t/001_auth.pl`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,8 @@ sub test_access`
`165`	`165`	`my ($node,$role,$expected_res,$test_name) =@_;`
`166`	`166`
`167`	`167`	`my$res =`
`168`		`-$node->psql('postgres','SELECT 1',extra_params=> ['-U',$role ]);`
	`168`	`+$node->psql('postgres',undef,`
	`169`	`+extra_params=> ['-U',$role,'-c','SELECT 1' ]);`
`169`	`170`	`is($res,$expected_res,$test_name);`
`170`	`171`	`return;`
`171`	`172`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf44b9b6

File tree

1 file changed

1 file changed

`‎src/test/ldap/t/001_auth.pl`

0 commit comments