NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf3bc519

committed

Fix off-by-one in LimitAdditionalPins()

Due to the bug LimitAdditionalPins() could return 0, violatingLimitAdditionalPins()'s API ("One additional pin is always allowed"). Thiscould be hit when setting shared_buffers very low and using a fair amount ofconcurrency.This bug was introduced in31966b1.Author: "Anton A. Melnikov" <aamelnikov@inbox.ru>Reported-by: "Anton A. Melnikov" <aamelnikov@inbox.ru>Reported-by: Victoria ShepardDiscussion:https://postgr.es/m/ae46f2fb-5586-3de0-b54b-1bb0f6410ebd@inbox.ruBackpatch: 16-

1 parentd6677b9 commitf3bc519Copy full SHA for f3bc519

File tree

1 file changed

-1

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-1

lines changed

`‎src/backend/storage/buffer/bufmgr.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1767,7 +1767,7 @@ LimitAdditionalPins(uint32 *additional_pins)`
`1767`	`1767`	`*/`
`1768`	`1768`	`max_proportional_pins-=PrivateRefCountOverflowed+REFCOUNT_ARRAY_ENTRIES;`
`1769`	`1769`
`1770`		`-if (max_proportional_pins<0)`
	`1770`	`+if (max_proportional_pins <=0)`
`1771`	`1771`	`max_proportional_pins=1;`
`1772`	`1772`
`1773`	`1773`	`if (*additional_pins>max_proportional_pins)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf3bc519

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c`

0 commit comments