NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf379121

committed

Suppress compiler warning in non-USE_LIBXML builds.

Compilers that don't realize that ereport(ERROR) doesn't returncomplained that XmlTableGetValue() failed to return a value.Also, make XmlTableFetchRow's non-USE_LIBXML case look more likethe other ones. As coded, it could lead to "unreachable code"warnings with USE_LIBXML enabled.Oversights in commitfcec6ca. Per buildfarm.

1 parent86dbbf2 commitf379121Copy full SHA for f379121

File tree

1 file changed

-2

lines changed

src/backend/utils/adt
- xml.c

1 file changed

-2

lines changed

`‎src/backend/utils/adt/xml.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4389,9 +4389,8 @@ XmlTableFetchRow(TableFuncScanState *state)`
`4389`	`4389`	`return false;`
`4390`	`4390`	`#else`
`4391`	`4391`	`NO_XML_SUPPORT();`
`4392`		`-#endif/* not USE_LIBXML */`
`4393`		`-`
`4394`	`4392`	`return false;`
	`4393`	`+#endif/* not USE_LIBXML */`
`4395`	`4394`	`}`
`4396`	`4395`
`4397`	`4396`	`/*`
`@@ -4561,6 +4560,7 @@ XmlTableGetValue(TableFuncScanState *state, int colnum,`
`4561`	`4560`	`returnresult;`
`4562`	`4561`	`#else`
`4563`	`4562`	`NO_XML_SUPPORT();`
	`4563`	`+return0;`
`4564`	`4564`	`#endif/* not USE_LIBXML */`
`4565`	`4565`	`}`
`4566`	`4566`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf379121

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/xml.c`

0 commit comments