NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf363368

committed

Fix pg_basebackup output to stdout on Windows.

When writing a backup to stdout with pg_basebackup on Windows, put stdoutto binary mode. Any CR bytes in the output will otherwise be outputincorrectly as CR+LF.In the passing, standardize on using "_setmode" instead of "setmode", forthe sake of consistency. They both do the same thing, but according toMSDN documentation, setmode is deprecated.Fixes bug #14634, reported by Henry Boehlert. Patch by Haribabu Kommi.Backpatch to all supported versions.Discussion:https://www.postgresql.org/message-id/20170428082818.24366.13134@wrigleys.postgresql.org

1 parent0ecc407 commitf363368Copy full SHA for f363368

File tree

2 files changed

-2

lines changed

src/bin
- pg_basebackup
  - pg_basebackup.c
- pg_dump
  - pg_backup_archiver.c

2 files changed

-2

lines changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -583,6 +583,10 @@ ReceiveTarFile(PGconn conn, PGresult res, int rownum)`
`583`	`583`	`*/`
`584`	`584`	`if (strcmp(basedir,"-")==0)`
`585`	`585`	`{`
	`586`	`+#ifdefWIN32`
	`587`	`+_setmode(fileno(stdout),_O_BINARY);`
	`588`	`+#endif`
	`589`	`+`
`586`	`590`	`#ifdefHAVE_LIBZ`
`587`	`591`	`if (compresslevel!=0)`
`588`	`592`	`{`

`‎src/bin/pg_dump/pg_backup_archiver.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2101,9 +2101,9 @@ _allocAH(const char *FileSpec, const ArchiveFormat fmt,`
`2101`	`2101`	`(AH->fSpec==NULL\|\|strcmp(AH->fSpec,"")==0))`
`2102`	`2102`	`{`
`2103`	`2103`	`if (mode==archModeWrite)`
`2104`		`-setmode(fileno(stdout),O_BINARY);`
	`2104`	`+_setmode(fileno(stdout),O_BINARY);`
`2105`	`2105`	`else`
`2106`		`-setmode(fileno(stdin),O_BINARY);`
	`2106`	`+_setmode(fileno(stdin),O_BINARY);`
`2107`	`2107`	`}`
`2108`	`2108`	`#endif`
`2109`	`2109`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf363368

File tree

2 files changed

2 files changed

`‎src/bin/pg_basebackup/pg_basebackup.c`

`‎src/bin/pg_dump/pg_backup_archiver.c`

0 commit comments