NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf35aef4

committed

Fix harmless access to uninitialized memory.

When cache invalidations arrive while ri_LoadConstraintInfo() is busyfilling a new cache entry, InvalidateConstraintCacheCallBack() comparesthe - not yet initialized - oidHashValue field with the to-be-invalidatedhash value. To fix, check whether the entry is already marked as invalid.Andres Freund

1 parent540ac7c commitf35aef4Copy full SHA for f35aef4

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- ri_triggers.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/ri_triggers.c‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2934,7 +2934,8 @@ InvalidateConstraintCacheCallBack(Datum arg, int cacheid, uint32 hashvalue)`
`2934`	`2934`	`hash_seq_init(&status,ri_constraint_cache);`
`2935`	`2935`	`while ((hentry= (RI_ConstraintInfo*)hash_seq_search(&status))!=NULL)`
`2936`	`2936`	`{`
`2937`		`-if (hashvalue==0\|\|hentry->oidHashValue==hashvalue)`
	`2937`	`+if (hentry->valid&&`
	`2938`	`+(hashvalue==0\|\|hentry->oidHashValue==hashvalue))`
`2938`	`2939`	`hentry->valid= false;`
`2939`	`2940`	`}`
`2940`	`2941`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf35aef4

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/ri_triggers.c‎`

0 commit comments