Commitf3412a6

committed

Avoid 0-length memcpy to NULL with EXEC_BACKEND

memcpy(NULL, src, 0) is forbidden by POSIX, even though everyproduction version of libc allows it. Let's be tidy.Per report from Thomas Munro, running UBSan with EXEC_BACKEND.Backpatch to v17, where this code was added.Discussion:https://www.postgresql.org/message-id/CA%2BhUKG%2Be-dV7YWBzfBZXsgovgRuX5VmvmOT%2Bv0aXiZJ-EKbXcw@mail.gmail.com

1 parenta06e8f8 commitf3412a6Copy full SHA for f3412a6

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -762,7 +762,8 @@ save_backend_variables(BackendParameters param, ClientSocket client_sock,`
`762`	`762`	`strlcpy(param->pkglib_path,pkglib_path,MAXPGPATH);`
`763`	`763`
`764`	`764`	`param->startup_data_len=startup_data_len;`
`765`		`-memcpy(param->startup_data,startup_data,startup_data_len);`
	`765`	`+if (startup_data_len>0)`
	`766`	`+memcpy(param->startup_data,startup_data,startup_data_len);`
`766`	`767`
`767`	`768`	`return true;`
`768`	`769`	`}`

Comments

(0)