NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf2a3d74

committed

Update minimum recovery point on truncation during WAL replay of abort record.

If a file is truncated, we must update minRecoveryPoint. Once a file istruncated, there's no going back; it would not be safe to stop recoveryat a point earlier than that anymore.Commit7bffc9b changed xact_redo_commit() so that it updatesminRecoveryPoint on truncation, but forgot to change xact_redo_abort().Back-patch to all supported versions.Reported-by: mengjuan.cmj@alibaba-inc.comAuthor: Fujii MasaoReviewed-by: Heikki LinnakangasDiscussion:https://postgr.es/m/b029fce3-4fac-4265-968e-16f36ff4d075.mengjuan.cmj@alibaba-inc.com

1 parentfc0d9b8 commitf2a3d74Copy full SHA for f2a3d74

File tree

1 file changed

+10

-1

lines changed

src/backend/access/transam
- xact.c

1 file changed

+10

-1

lines changed

`‎src/backend/access/transam/xact.c‎`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5983,7 +5983,16 @@ xact_redo_abort(xl_xact_parsed_abort *parsed, TransactionId xid,`
`5983`	`5983`	`}`
`5984`	`5984`
`5985`	`5985`	`/* Make sure files supposed to be dropped are dropped */`
`5986`		`-DropRelationFiles(parsed->xnodes,parsed->nrels, true);`
	`5986`	`+if (parsed->nrels>0)`
	`5987`	`+{`
	`5988`	`+/*`
	`5989`	`+ * See comments about update of minimum recovery point on truncation,`
	`5990`	`+ * in xact_redo_commit().`
	`5991`	`+ */`
	`5992`	`+XLogFlush(lsn);`
	`5993`	`+`
	`5994`	`+DropRelationFiles(parsed->xnodes,parsed->nrels, true);`
	`5995`	`+}`
`5987`	`5996`	`}`
`5988`	`5997`
`5989`	`5998`	`void`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf2a3d74

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xact.c‎`

0 commit comments