NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf25a458

Amit Kapila

committed

Avoid sending prepare multiple times while decoding.

We send the prepare for the concurrently aborted xacts so that later whenrollback prepared is decoded and sent, the downstream should be able torollback such a xact. For 'streaming' case (when we send changes forin-progress transactions), we were sending prepare twice when concurrentabort was detected.Author: Peter SmithReviewed-by: Amit KapilaDiscussion:https://postgr.es/m/f82133c6-6055-b400-7922-97dae9f2b50b@enterprisedb.com

1 parent3cbea58 commitf25a458Copy full SHA for f25a458

File tree

1 file changed

-1

lines changed

src/backend/replication/logical
- reorderbuffer.c

1 file changed

-1

lines changed

`‎src/backend/replication/logical/reorderbuffer.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2690,8 +2690,11 @@ ReorderBufferPrepare(ReorderBuffer *rb, TransactionId xid,`
`2690`	`2690`	`* We send the prepare for the concurrently aborted xacts so that later`
`2691`	`2691`	`* when rollback prepared is decoded and sent, the downstream should be`
`2692`	`2692`	`* able to rollback such a xact. See comments atop DecodePrepare.`
	`2693`	`+ *`
	`2694`	`+ * Note, for the concurrent_abort + streaming case a stream_prepare was`
	`2695`	`+ * already sent within the ReorderBufferReplay call above.`
`2693`	`2696`	`*/`
`2694`		`-if (txn->concurrent_abort)`
	`2697`	`+if (txn->concurrent_abort&& !rbtxn_is_streamed(txn))`
`2695`	`2698`	`rb->prepare(rb,txn,txn->final_lsn);`
`2696`	`2699`	`}`
`2697`	`2700`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf25a458

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/reorderbuffer.c`

0 commit comments