NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf22c6f9

committed

the following patch fixes a bug in the oracle compatibility

functions btrim() ltrim() and rtrim(). The error was that the character after the set was included in the tests (ptr2 pointed to the character after the vardata part of set if no match found, so comparing *ptr or *end against *ptr2 MAY match -> strip).Jan--#======================================================================## It's easier to get forgiveness for being wrong than for beingright. # # Let's break this rule - forgive me.# #======================================== jwieck@debis.com (JanWieck) #

1 parentc6dd1e6 commitf22c6f9Copy full SHA for f22c6f9

File tree

1 file changed

-5

lines changed

src/backend/utils/adt
- oracle_compat.c

1 file changed

-5

lines changed

`‎src/backend/utils/adt/oracle_compat.c`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/*`
`2`	`2`	`*Edmund Mergl <E.Mergl@bawue.de>`
`3`	`3`	`*`
`4`		`- *$Id: oracle_compat.c,v 1.14 1998/06/15 19:29:36 momjian Exp $`
	`4`	`+ *$Id: oracle_compat.c,v 1.15 1998/08/11 18:38:07 momjian Exp $`
`5`	`5`	`*`
`6`	`6`	`*/`
`7`	`7`
`@@ -297,7 +297,7 @@ btrim(text string, text set)`
`297`	`297`	`break;`
`298`	`298`	`++ptr2;`
`299`	`299`	`}`
`300`		`-if (ptr!=ptr2)`
	`300`	`+if (ptr2>end2)`
`301`	`301`	`break;`
`302`	`302`	`ptr++;`
`303`	`303`	`ptr2=VARDATA(set);`
`@@ -316,7 +316,7 @@ btrim(text string, text set)`
`316`	`316`	`break;`
`317`	`317`	`++ptr2;`
`318`	`318`	`}`
`319`		`-if (end!=ptr2)`
	`319`	`+if (ptr2>end2)`
`320`	`320`	`break;`
`321`	`321`	`--end;`
`322`	`322`	`ptr2=VARDATA(set);`
`@@ -374,7 +374,7 @@ ltrim(text string, text set)`
`374`	`374`	`break;`
`375`	`375`	`++ptr2;`
`376`	`376`	`}`
`377`		`-if (ptr!=ptr2)`
	`377`	`+if (ptr2>end2)`
`378`	`378`	`break;`
`379`	`379`	`ptr++;`
`380`	`380`	`ptr2=VARDATA(set);`
`@@ -434,7 +434,7 @@ rtrim(text string, text set)`
`434`	`434`	`break;`
`435`	`435`	`++ptr2;`
`436`	`436`	`}`
`437`		`-if (ptr!=ptr2)`
	`437`	`+if (ptr2>end2)`
`438`	`438`	`break;`
`439`	`439`	`--ptr;`
`440`	`440`	`ptr2=VARDATA(set);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf22c6f9

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/oracle_compat.c`

0 commit comments