NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf198f0a

committed

pg_dump: Remove some dead code

Client-side tracking of atttypmod has been unused since64f3524, whenserver-side format_type() started being used exclusively. So removethis dead code.Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>Discussion:https://www.postgresql.org/message-id/flat/144be239-c893-9361-704f-ac85b5b98d1a%40enterprisedb.com

1 parent8bf5af2 commitf198f0aCopy full SHA for f198f0a

File tree

2 files changed

-6

lines changed

src/bin/pg_dump
- pg_dump.c
- pg_dump.h

2 files changed

-6

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -8182,7 +8182,6 @@ getTableAttrs(Archive fout, TableInfo tblinfo, int numTables)`
`8182`	`8182`	`inti_attnum;`
`8183`	`8183`	`inti_attname;`
`8184`	`8184`	`inti_atttypname;`
`8185`		`-inti_atttypmod;`
`8186`	`8185`	`inti_attstattarget;`
`8187`	`8186`	`inti_attstorage;`
`8188`	`8187`	`inti_typstorage;`
`@@ -8252,7 +8251,6 @@ getTableAttrs(Archive fout, TableInfo tblinfo, int numTables)`
`8252`	`8251`	`"a.attrelid,\n"`
`8253`	`8252`	`"a.attnum,\n"`
`8254`	`8253`	`"a.attname,\n"`
`8255`		`- "a.atttypmod,\n"`
`8256`	`8254`	`"a.attstattarget,\n"`
`8257`	`8255`	`"a.attstorage,\n"`
`8258`	`8256`	`"t.typstorage,\n"`
`@@ -8320,7 +8318,6 @@ getTableAttrs(Archive fout, TableInfo tblinfo, int numTables)`
`8320`	`8318`	`i_attnum = PQfnumber(res, "attnum");`
`8321`	`8319`	`i_attname = PQfnumber(res, "attname");`
`8322`	`8320`	`i_atttypname = PQfnumber(res, "atttypname");`
`8323`		`-i_atttypmod = PQfnumber(res, "atttypmod");`
`8324`	`8321`	`i_attstattarget = PQfnumber(res, "attstattarget");`
`8325`	`8322`	`i_attstorage = PQfnumber(res, "attstorage");`
`8326`	`8323`	`i_typstorage = PQfnumber(res, "typstorage");`
`@@ -8381,7 +8378,6 @@ getTableAttrs(Archive fout, TableInfo tblinfo, int numTables)`
`8381`	`8378`	`tbinfo->numatts = numatts;`
`8382`	`8379`	`tbinfo->attnames = (char *) pg_malloc(numatts sizeof(char *));`
`8383`	`8380`	`tbinfo->atttypnames = (char *) pg_malloc(numatts sizeof(char *));`
`8384`		`-tbinfo->atttypmod = (int ) pg_malloc(numatts sizeof(int));`
`8385`	`8381`	`tbinfo->attstattarget = (int ) pg_malloc(numatts sizeof(int));`
`8386`	`8382`	`tbinfo->attstorage = (char ) pg_malloc(numatts sizeof(char));`
`8387`	`8383`	`tbinfo->typstorage = (char ) pg_malloc(numatts sizeof(char));`
`@@ -8408,7 +8404,6 @@ getTableAttrs(Archive fout, TableInfo tblinfo, int numTables)`
`8408`	`8404`	`tbinfo->dobj.name);`
`8409`	`8405`	`tbinfo->attnames[j] = pg_strdup(PQgetvalue(res, r, i_attname));`
`8410`	`8406`	`tbinfo->atttypnames[j] = pg_strdup(PQgetvalue(res, r, i_atttypname));`
`8411`		`-tbinfo->atttypmod[j] = atoi(PQgetvalue(res, r, i_atttypmod));`
`8412`	`8407`	`tbinfo->attstattarget[j] = atoi(PQgetvalue(res, r, i_attstattarget));`
`8413`	`8408`	`tbinfo->attstorage[j] = *(PQgetvalue(res, r, i_attstorage));`
`8414`	`8409`	`tbinfo->typstorage[j] = *(PQgetvalue(res, r, i_typstorage));`

`‎src/bin/pg_dump/pg_dump.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,6 @@ typedef struct _tableInfo`
`326`	`326`	`intnumatts;/* number of attributes */`
`327`	`327`	`char*attnames;/ the attribute names */`
`328`	`328`	`char*atttypnames;/ attribute type names */`
`329`		`-intatttypmod;/ type-specific type modifiers */`
`330`	`329`	`intattstattarget;/ attribute statistics targets */`
`331`	`330`	`charattstorage;/ attribute storage scheme */`
`332`	`331`	`chartypstorage;/ type storage scheme */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf198f0a

File tree

2 files changed

2 files changed

`‎src/bin/pg_dump/pg_dump.c`

`‎src/bin/pg_dump/pg_dump.h`

0 commit comments