NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitf18cad9

committed

Fix atomic ops inline x86 inline assembly for older 32bit gccs.

Some x86 32bit versions of gcc apparently generate references to thenonexistant %sil register when using when using the r inputconstraint, but not with the =q constraint. The latter restrictsallocations to a/b/c/d which should all work.

1 parent88bcdf9 commitf18cad9Copy full SHA for f18cad9

File tree

1 file changed

-2

lines changed

src/include/port/atomics
- arch-x86.h

1 file changed

-2

lines changed

`‎src/include/port/atomics/arch-x86.h`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ pg_atomic_compare_exchange_u32_impl(volatile pg_atomic_uint32 *ptr,`
`175`	`175`	`"lock\n"`
`176`	`176`	`"cmpxchgl%4,%5\n"`
`177`	`177`	`" setz%2\n"`
`178`		`-:"=a" (*expected),"=m"(ptr->value),"=r" (ret)`
	`178`	`+:"=a" (*expected),"=m"(ptr->value),"=q" (ret)`
`179`	`179`	`:"a" (*expected),"r" (newval),"m"(ptr->value)`
`180`	`180`	`:"memory","cc");`
`181`	`181`	`return (bool)ret;`
`@@ -212,7 +212,7 @@ pg_atomic_compare_exchange_u64_impl(volatile pg_atomic_uint64 *ptr,`
`212`	`212`	`"lock\n"`
`213`	`213`	`"cmpxchgq%4,%5\n"`
`214`	`214`	`" setz%2\n"`
`215`		`-:"=a" (*expected),"=m"(ptr->value),"=r" (ret)`
	`215`	`+:"=a" (*expected),"=m"(ptr->value),"=q" (ret)`
`216`	`216`	`:"a" (*expected),"r" (newval),"m"(ptr->value)`
`217`	`217`	`:"memory","cc");`
`218`	`218`	`return (bool)ret;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitf18cad9

File tree

1 file changed

1 file changed

`‎src/include/port/atomics/arch-x86.h`

0 commit comments