Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitf185f35

Browse files
committed
Allow special SKIP LOCKED condition in Assert()
Under concurrency, it is possible for two sessions to be merrily lockingand releasing a tuple and marking it again as HEAP_XMAX_INVALID all thewhile a third session attempts to lock it, miserably fails at it, andthen contemplates life, the universe and everything only to eventuallyfail an assertion that said bit is not set. Before SKIP LOCKED that wasindeed a reasonable expectation, but alas! commitdf630b0 falsifiedit.This bug is as old as time itself, and even older, if you think timebegins with the oldest supported branch. Therefore, backpatch to allsupported branches.Author: Simon Riggs <simon.riggs@enterprisedb.com>Discussion:https://postgr.es/m/CANbhV-FeEwMnN8yuMyss7if1ZKjOKfjcgqB26n8pqu1e=q0ebg@mail.gmail.com
1 parentd228af7 commitf185f35

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

‎src/backend/access/heap/heapam.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4770,7 +4770,15 @@ heap_lock_tuple(Relation relation, HeapTuple tuple,
47704770
{
47714771
Assert(result==TM_SelfModified||result==TM_Updated||
47724772
result==TM_Deleted||result==TM_WouldBlock);
4773-
Assert(!(tuple->t_data->t_infomask&HEAP_XMAX_INVALID));
4773+
4774+
/*
4775+
* When locking a tuple under LockWaitSkip semantics and we fail with
4776+
* TM_WouldBlock above, it's possible for concurrent transactions to
4777+
* release the lock and set HEAP_XMAX_INVALID in the meantime. So
4778+
* this assert is slightly different from the equivalent one in
4779+
* heap_delete and heap_update.
4780+
*/
4781+
Assert(TM_WouldBlock|| !(tuple->t_data->t_infomask&HEAP_XMAX_INVALID));
47744782
Assert(result!=TM_Updated||
47754783
!ItemPointerEquals(&tuple->t_self,&tuple->t_data->t_ctid));
47764784
tmfd->ctid=tuple->t_data->t_ctid;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp