Commitf0ff52f

committed

Avoid memcpy() with a NULL source pointer and count == 0

When memcpy() is called on a pointer, the compiler is entitled to assumethat the pointer is not null, which can lead to optimizing nearby codein potentially undesirable ways. We still want such optimizations(gcc's -fdelete-null-pointer-checks) in cases where they're valid.Related: commit13bba02.Backpatch to pg11, where this particular instance appeared.Reported-by: Ranier Vilela <ranier.vf@gmail.com>Reported-by: Zhihong Yu <zyu@yugabyte.com>Discussion:https://postgr.es/m/CAEudQApUndmQkr5fLrCKXQ7+ib44i7S+Kk93pyVThS85PnG3bQ@mail.gmail.comDiscussion:https://postgr.es/m/CALNJ-vSdhwSM5f4tnNn1cdLHvXMVe_S+V3nR5GwNrmCPNB2VtQ@mail.gmail.com

1 parent50f3385 commitf0ff52fCopy full SHA for f0ff52f

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1091,15 +1091,17 @@ DefineIndex(Oid relationId,`
`1091`	`1091`
`1092`	`1092`	`if (partitioned)`
`1093`	`1093`	`{`
	`1094`	`+PartitionDescpartdesc;`
	`1095`	`+`
`1094`	`1096`	`/*`
`1095`	`1097`	`* Unless caller specified to skip this step (via ONLY), process each`
`1096`	`1098`	`* partition to make sure they all contain a corresponding index.`
`1097`	`1099`	`*`
`1098`	`1100`	`* If we're called internally (no stmt->relation), recurse always.`
`1099`	`1101`	`*/`
`1100`		`-if (!stmt->relation\|\|stmt->relation->inh)`
	`1102`	`+partdesc=RelationGetPartitionDesc(rel);`
	`1103`	`+if ((!stmt->relation\|\|stmt->relation->inh)&&partdesc->nparts>0)`
`1101`	`1104`	`{`
`1102`		`-PartitionDescpartdesc=RelationGetPartitionDesc(rel);`
`1103`	`1105`	`intnparts=partdesc->nparts;`
`1104`	`1106`	`Oidpart_oids=palloc(sizeof(Oid)nparts);`
`1105`	`1107`	`boolinvalidate_parent= false;`

Comments

(0)