forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitf0d1127
committed
Remove "parent" column from pg_backend_memory_contexts
32d3ed8 added the "path" column to pg_backend_memory_contexts to allowa stable method of obtaining the parent MemoryContext of a given row inthe view. Using the "path" column is now the preferred method ofobtaining the parent row.Previously, any queries which were self-joining to this view using the"name" and "parent" columns could get incorrect results due to the factthat names are not unique. Here we aim to explicitly break such queriesso that they can be corrected and use the "path" column instead.It is possible that there are more innocent users of the parent columnthat just need an indication of the parent and having to write out aself-joining CTE may be an unnecessary hassle for those cases. Let'sremove the column for now and see if anyone comes back with anycomplaints. This does seem like a good time to attempt to get rid ofthe column as we still have around 1 year to revert this if someone comesback with a valid complaint. Plus this view is new to v14 and is quiteniche, so perhaps not many people will be affected.Author: Melih Mutlu <m.melihmutlu@gmail.com>Discussion:https://postgr.es/m/CAGPVpCT7NOe4fZXRL8XaoxHpSXYTu6GTpULT_3E-HT9hzjoFRA@mail.gmail.com1 parent3f44959 commitf0d1127
File tree
7 files changed
+36
-69
lines changed- doc/src/sgml
- src
- backend/utils/adt
- include/catalog
- test/regress
- expected
- sql
7 files changed
+36
-69
lines changedLines changed: 0 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
481 | 481 |
| |
482 | 482 |
| |
483 | 483 |
| |
484 |
| - | |
485 |
| - | |
486 |
| - | |
487 |
| - | |
488 |
| - | |
489 |
| - | |
490 |
| - | |
491 |
| - | |
492 |
| - | |
493 | 484 |
| |
494 | 485 |
| |
495 | 486 |
| |
|
Lines changed: 21 additions & 44 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
40 | 40 |
| |
41 | 41 |
| |
42 | 42 |
| |
43 |
| - | |
44 |
| - | |
45 |
| - | |
46 |
| - | |
47 |
| - | |
48 |
| - | |
49 |
| - | |
50 |
| - | |
51 |
| - | |
52 |
| - | |
53 |
| - | |
54 |
| - | |
55 |
| - | |
56 |
| - | |
57 |
| - | |
58 |
| - | |
59 |
| - | |
60 |
| - | |
61 |
| - | |
62 |
| - | |
63 |
| - | |
64 |
| - | |
65 | 43 |
| |
66 | 44 |
| |
67 | 45 |
| |
| |||
93 | 71 |
| |
94 | 72 |
| |
95 | 73 |
| |
96 |
| - | |
| 74 | + | |
97 | 75 |
| |
98 | 76 |
| |
99 | 77 |
| |
| |||
128 | 106 |
| |
129 | 107 |
| |
130 | 108 |
| |
131 |
| - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
132 | 121 |
| |
133 | 122 |
| |
134 | 123 |
| |
| |||
154 | 143 |
| |
155 | 144 |
| |
156 | 145 |
| |
157 |
| - | |
158 |
| - | |
159 |
| - | |
160 |
| - | |
161 |
| - | |
162 |
| - | |
163 |
| - | |
164 |
| - | |
165 |
| - | |
166 |
| - | |
167 |
| - | |
168 |
| - | |
169 | 146 |
| |
170 | 147 |
| |
171 | 148 |
| |
| |||
185 | 162 |
| |
186 | 163 |
| |
187 | 164 |
| |
188 |
| - | |
189 |
| - | |
190 |
| - | |
191 |
| - | |
192 |
| - | |
193 |
| - | |
194 |
| - | |
195 |
| - | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
196 | 173 |
| |
197 | 174 |
| |
198 | 175 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
57 | 57 |
| |
58 | 58 |
| |
59 | 59 |
| |
60 |
| - | |
| 60 | + | |
61 | 61 |
| |
62 | 62 |
|
Lines changed: 3 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
8329 | 8329 |
| |
8330 | 8330 |
| |
8331 | 8331 |
| |
8332 |
| - | |
8333 |
| - | |
8334 |
| - | |
| 8332 | + | |
| 8333 | + | |
| 8334 | + | |
8335 | 8335 |
| |
8336 | 8336 |
| |
8337 | 8337 |
| |
|
Lines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1305 | 1305 |
| |
1306 | 1306 |
| |
1307 | 1307 |
| |
1308 |
| - | |
1309 | 1308 |
| |
1310 | 1309 |
| |
1311 | 1310 |
| |
| |||
1314 | 1313 |
| |
1315 | 1314 |
| |
1316 | 1315 |
| |
1317 |
| - | |
| 1316 | + | |
1318 | 1317 |
| |
1319 | 1318 |
| |
1320 | 1319 |
| |
|
Lines changed: 8 additions & 8 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
21 | 21 |
| |
22 | 22 |
| |
23 | 23 |
| |
24 |
| - | |
| 24 | + | |
25 | 25 |
| |
26 |
| - | |
27 |
| - | |
28 |
| - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
29 | 29 |
| |
30 | 30 |
| |
31 | 31 |
| |
| |||
43 | 43 |
| |
44 | 44 |
| |
45 | 45 |
| |
46 |
| - | |
| 46 | + | |
47 | 47 |
| |
48 |
| - | |
49 |
| - | |
50 |
| - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
51 | 51 |
| |
52 | 52 |
| |
53 | 53 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
14 | 14 |
| |
15 | 15 |
| |
16 | 16 |
| |
17 |
| - | |
| 17 | + | |
18 | 18 |
| |
19 | 19 |
| |
20 | 20 |
| |
| |||
28 | 28 |
| |
29 | 29 |
| |
30 | 30 |
| |
31 |
| - | |
| 31 | + | |
32 | 32 |
| |
33 | 33 |
| |
34 | 34 |
| |
|
0 commit comments
Comments
(0)