Commitf0a94d8

committed

Fix type of iterator variable in SH_START_ITERATE

Also add comment to make the reasoning behind the Assert() more explicit (perTom).Reported-by: Ranier VilelaDiscussion:https://postgr.es/m/CAEudQAocXNJ6s1VLz+hMamLAQAiewRoW17OJ6-+9GACKfj6iPQ@mail.gmail.comBackpatch: 11-

1 parent1fa25ce commitf0a94d8Copy full SHA for f0a94d8

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -964,15 +964,14 @@ SH_DELETE_ITEM(SH_TYPE * tb, SH_ELEMENT_TYPE * entry)`
`964`	`964`	`SH_SCOPEvoid`
`965`	`965`	`SH_START_ITERATE(SH_TYPEtb,SH_ITERATORiter)`
`966`	`966`	`{`
`967`		`-inti;`
`968`	`967`	`uint64startelem=PG_UINT64_MAX;`
`969`	`968`
`970`	`969`	`/*`
`971`	`970`	`* Search for the first empty element. As deletions during iterations are`
`972`	`971`	`* supported, we want to start/end at an element that cannot be affected`
`973`	`972`	`* by elements being shifted.`
`974`	`973`	`*/`
`975`		`-for (i=0;i<tb->size;i++)`
	`974`	`+for (uint32i=0;i<tb->size;i++)`
`976`	`975`	`{`
`977`	`976`	`SH_ELEMENT_TYPE*entry=&tb->data[i];`
`978`	`977`
`@@ -983,6 +982,7 @@ SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter)`
`983`	`982`	`}`
`984`	`983`	`}`
`985`	`984`
	`985`	`+/* we should have found an empty element */`
`986`	`986`	`Assert(startelem<SH_MAX_SIZE);`
`987`	`987`
`988`	`988`	`/*`

Comments

(0)