Commitf06588a

committed

Exclude special values in recovery_target_time

recovery_target_time accepts timestamp input, thoughdoes not allow use of special values, e.g. “today”.Report a useful error message for these cases.Reported-by: Piotr StefaniakAuthor: Simon RiggsDiscussion:https://postgr.es/m/CANP8+jJdKA+BkkYLWz9zAm16Y0s2ExBv0WfpAwXdTpPfWnA9Bg@mail.gmail.com

1 parent793a89c commitf06588aCopy full SHA for f06588a

File tree

+12

-0

lines changed

+12

-0

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -5265,6 +5265,18 @@ readRecoveryCommandFile(void)`
`5265`	`5265`	`{`
`5266`	`5266`	`recoveryTarget=RECOVERY_TARGET_TIME;`
`5267`	`5267`
	`5268`	`+if (strcmp(item->value,"epoch")==0\|\|`
	`5269`	`+strcmp(item->value,"infinity")==0\|\|`
	`5270`	`+strcmp(item->value,"-infinity")==0\|\|`
	`5271`	`+strcmp(item->value,"now")==0\|\|`
	`5272`	`+strcmp(item->value,"today")==0\|\|`
	`5273`	`+strcmp(item->value,"tomorrow")==0\|\|`
	`5274`	`+strcmp(item->value,"yesterday")==0)`
	`5275`	`+ereport(FATAL,`
	`5276`	`+(errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
	`5277`	`+errmsg("recovery_target_time is not a valid timestamp: \"%s\"",`
	`5278`	`+item->value)));`
	`5279`	`+`
`5268`	`5280`	`/*`
`5269`	`5281`	`* Convert the time string given by the user to TimestampTz form.`
`5270`	`5282`	`*/`

Comments

(0)