NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitefa70c1

committed

Make GetSlotInvalidationCause() return RS_INVAL_NONE on unexpected input

943f7ae has changed GetSlotInvalidationCause() so as it wouldreturn the last element of SlotInvalidationCauses[] when an incorrectconflict reason name is given by a caller, but this should returnRS_INVAL_NONE in such cases, even if such a state should never bereached in practice.Per gripe from Peter Smith.Reviewed-by: Bharath RupireddyDiscussion:https://postgr.es/m/CAHut+PtsrSWxczpGkSaSVtJo+BXrvJ3Hwp5gES14bbL-G+HL7A@mail.gmail.com

1 parent93db6cb commitefa70c1Copy full SHA for efa70c1

File tree

1 file changed

-1

lines changed

src/backend/replication
- slot.c

1 file changed

-1

lines changed

`‎src/backend/replication/slot.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2327,6 +2327,7 @@ ReplicationSlotInvalidationCause`
`2327`	`2327`	`GetSlotInvalidationCause(constchar*conflict_reason)`
`2328`	`2328`	`{`
`2329`	`2329`	`ReplicationSlotInvalidationCausecause;`
	`2330`	`+ReplicationSlotInvalidationCauseresult=RS_INVAL_NONE;`
`2330`	`2331`	`boolfoundPG_USED_FOR_ASSERTS_ONLY= false;`
`2331`	`2332`
`2332`	`2333`	`Assert(conflict_reason);`
`@@ -2336,10 +2337,11 @@ GetSlotInvalidationCause(const char *conflict_reason)`
`2336`	`2337`	`if (strcmp(SlotInvalidationCauses[cause],conflict_reason)==0)`
`2337`	`2338`	`{`
`2338`	`2339`	`found= true;`
	`2340`	`+result=cause;`
`2339`	`2341`	`break;`
`2340`	`2342`	`}`
`2341`	`2343`	`}`
`2342`	`2344`
`2343`	`2345`	`Assert(found);`
`2344`		`-returncause;`
	`2346`	`+returnresult;`
`2345`	`2347`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitefa70c1

File tree

1 file changed

1 file changed

`‎src/backend/replication/slot.c`

0 commit comments