NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitef88638

committed

Rename CACHE_LINE_SIZE to PG_CACHE_LINE_SIZE.

As noted inhttp://bugs.debian.org/763098 there is a conflict betweenpostgres' definition of CACHE_LINE_SIZE and the definition by various*bsd platforms. It's debatable who has the right to define such aname, but postgres' use was only introduced in375d852 (9.4), soit seems like a good idea to rename it.Discussion: 20140930195756.GC27407@msg.df7cb.dePer complaint of Christoph Berg in the above email, although he's notthe original bug reporter.Backpatch to 9.4 where the define was introduced.

1 parent8492d86 commitef88638Copy full SHA for ef88638

File tree

2 files changed

-3

lines changed

src
- backend/access/transam
  - xlog.c
- include
  - pg_config_manual.h

2 files changed

-3

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ typedef struct`
`409`	`409`	`typedefunionWALInsertLockPadded`
`410`	`410`	`{`
`411`	`411`	`WALInsertLockl;`
`412`		`-charpad[CACHE_LINE_SIZE];`
	`412`	`+charpad[PG_CACHE_LINE_SIZE];`
`413`	`413`	`}WALInsertLockPadded;`
`414`	`414`
`415`	`415`	`/*`
`@@ -436,7 +436,7 @@ typedef struct XLogCtlInsert`
`436`	`436`	`* read on every WAL insertion, but updated rarely, and we don't want`
`437`	`437`	`* those reads to steal the cache line containing Curr/PrevBytePos.`
`438`	`438`	`*/`
`439`		`-charpad[CACHE_LINE_SIZE];`
	`439`	`+charpad[PG_CACHE_LINE_SIZE];`
`440`	`440`
`441`	`441`	`/*`
`442`	`442`	`* fullPageWrites is the master copy used by all backends to determine`

`‎src/include/pg_config_manual.h`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@`
`238`	`238`	`* bytes of wasted memory. The default is 128, which should be large enough`
`239`	`239`	`* for all supported platforms.`
`240`	`240`	`*/`
`241`		`-#defineCACHE_LINE_SIZE128`
	`241`	`+#definePG_CACHE_LINE_SIZE128`
`242`	`242`
`243`	`243`	`/*`
`244`	`244`	`*------------------------------------------------------------------------`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitef88638

File tree

2 files changed

2 files changed

`‎src/backend/access/transam/xlog.c`

`‎src/include/pg_config_manual.h`

0 commit comments