Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commiteef34e5

Browse files
committed
test_decoding: Protect against rare spurious test failures.
A bunch of tests missed specifying that empty transactions shouldn't bedisplayed. That causes problems when e.g. autovacuum runs in anunfortunate moment. The tests in question only run for a very shorttime, making this quite unlikely.Reported-By: Buildfarm member axolotlBackpatch: 9.4, where logical decoding was introduced
1 parent98d5b08 commiteef34e5

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

‎contrib/test_decoding/expected/binary.out

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,22 @@ SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_d
77
(1 row)
88

99
-- succeeds, textual plugin, textual consumer
10-
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'force-binary', '0');
10+
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'force-binary', '0', 'skip-empty-xacts', '1');
1111
data
1212
------
1313
(0 rows)
1414

1515
-- fails, binary plugin, textual consumer
16-
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'force-binary', '1');
16+
SELECT data FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'force-binary', '1', 'skip-empty-xacts', '1');
1717
ERROR: logical decoding output plugin "test_decoding" produces binary output, but "pg_logical_slot_get_changes(name,pg_lsn,integer,text[])" expects textual data
1818
-- succeeds, textual plugin, binary consumer
19-
SELECT data FROM pg_logical_slot_get_binary_changes('regression_slot', NULL, NULL, 'force-binary', '0');
19+
SELECT data FROM pg_logical_slot_get_binary_changes('regression_slot', NULL, NULL, 'force-binary', '0', 'skip-empty-xacts', '1');
2020
data
2121
------
2222
(0 rows)
2323

2424
-- succeeds, binary plugin, binary consumer
25-
SELECT data FROM pg_logical_slot_get_binary_changes('regression_slot', NULL, NULL, 'force-binary', '1');
25+
SELECT data FROM pg_logical_slot_get_binary_changes('regression_slot', NULL, NULL, 'force-binary', '1', 'skip-empty-xacts', '1');
2626
data
2727
------
2828
(0 rows)

‎contrib/test_decoding/sql/binary.sql

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ SET synchronous_commit = on;
33

44
SELECT'init'FROM pg_create_logical_replication_slot('regression_slot','test_decoding');
55
-- succeeds, textual plugin, textual consumer
6-
SELECT dataFROM pg_logical_slot_get_changes('regression_slot',NULL,NULL,'force-binary','0');
6+
SELECT dataFROM pg_logical_slot_get_changes('regression_slot',NULL,NULL,'force-binary','0','skip-empty-xacts','1');
77
-- fails, binary plugin, textual consumer
8-
SELECT dataFROM pg_logical_slot_get_changes('regression_slot',NULL,NULL,'force-binary','1');
8+
SELECT dataFROM pg_logical_slot_get_changes('regression_slot',NULL,NULL,'force-binary','1','skip-empty-xacts','1');
99
-- succeeds, textual plugin, binary consumer
10-
SELECT dataFROM pg_logical_slot_get_binary_changes('regression_slot',NULL,NULL,'force-binary','0');
10+
SELECT dataFROM pg_logical_slot_get_binary_changes('regression_slot',NULL,NULL,'force-binary','0','skip-empty-xacts','1');
1111
-- succeeds, binary plugin, binary consumer
12-
SELECT dataFROM pg_logical_slot_get_binary_changes('regression_slot',NULL,NULL,'force-binary','1');
12+
SELECT dataFROM pg_logical_slot_get_binary_changes('regression_slot',NULL,NULL,'force-binary','1','skip-empty-xacts','1');
1313

1414
SELECT'init'FROM pg_drop_replication_slot('regression_slot');

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp