NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commiteee381e

committed

Fix function code in error report

This bug causes a lseek() failure to be reported as a "could not open"failure in the error message, muddling bug reports. I introduced thiscopy-and-pasteo in commit78e1220.Noticed while reviewing code for bug report #15221, from lily liang. Inversion 10 the affected function is only used by multixact.c andcommit_ts, and only in corner-case circumstances, neither of which areinvolved in the reported bug (a pg_subtrans failure.)Author: Álvaro Herrera

1 parent3f85c62 commiteee381eCopy full SHA for eee381e

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- slru.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/slru.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -614,7 +614,7 @@ SimpleLruDoesPhysicalPageExist(SlruCtl ctl, int pageno)`
`614`	`614`
`615`	`615`	`if ((endpos=lseek(fd,0,SEEK_END))<0)`
`616`	`616`	`{`
`617`		`-slru_errcause=SLRU_OPEN_FAILED;`
	`617`	`+slru_errcause=SLRU_SEEK_FAILED;`
`618`	`618`	`slru_errno=errno;`
`619`	`619`	`SlruReportIOError(ctl,pageno,0);`
`620`	`620`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commiteee381e

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/slru.c`

0 commit comments