Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitee492e3

Browse files
committed
Add HOLD_INTERRUPTS section into FinishPreparedTransaction.
If an interrupt arrives in the middle of FinishPreparedTransactionand any callback decide to call CHECK_FOR_INTERRUPTS (e.g.RemoveTwoPhaseFile can write a warning with ereport, which checks forinterrupts) then it's possible to leave current GXact undeleted.Backpatch to all supported branchesStas KelvichDiscussion: ihttps://www.postgresql.org/message-id/3AD85097-A3F3-4EBA-99BD-C38EDF8D2949@postgrespro.ru
1 parentf74d83b commitee492e3

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

‎src/backend/access/transam/twophase.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1421,6 +1421,9 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
14211421
/* compute latestXid among all children */
14221422
latestXid=TransactionIdLatest(xid,hdr->nsubxacts,children);
14231423

1424+
/* Prevent cancel/die interrupt while cleaning up */
1425+
HOLD_INTERRUPTS();
1426+
14241427
/*
14251428
* The order of operations here is critical: make the XLOG entry for
14261429
* commit or abort, then mark the transaction committed or aborted in
@@ -1511,6 +1514,8 @@ FinishPreparedTransaction(const char *gid, bool isCommit)
15111514
LWLockRelease(TwoPhaseStateLock);
15121515
MyLockedGxact=NULL;
15131516

1517+
RESUME_INTERRUPTS();
1518+
15141519
pfree(buf);
15151520
}
15161521

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp