NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitee40e89

committed

Teach pg_ls_dir_files() to ignore ENOENT failures from stat().

Buildfarm experience shows that this function can fail with ENOENTif some other process unlinks a file between when we read the directoryentry and when we try to stat() it. The problem is old but we hadnot noticed it until085b6b6 added regression test coverage.To fix, just ignore ENOENT failures. There is one other case thatthis might hide: a symlink that points to nowhere. That seems okaythough, at least better than erroring.Back-patch to v10 where this function was added, since the regressiontest cases were too.Discussion:https://postgr.es/m/20200308173103.GC1357@telsasoft.com

1 parent94c9152 commitee40e89Copy full SHA for ee40e89

File tree

1 file changed

-0

lines changed

src/backend/utils/adt
- genfile.c

1 file changed

-0

lines changed

`‎src/backend/utils/adt/genfile.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -596,9 +596,14 @@ pg_ls_dir_files(FunctionCallInfo fcinfo, const char *dir, bool missing_ok)`
`596`	`596`	`/* Get the file info */`
`597`	`597`	`snprintf(path,sizeof(path),"%s/%s",dir,de->d_name);`
`598`	`598`	`if (stat(path,&attrib)<0)`
	`599`	`+{`
	`600`	`+/* Ignore concurrently-deleted files, else complain */`
	`601`	`+if (errno==ENOENT)`
	`602`	`+continue;`
`599`	`603`	`ereport(ERROR,`
`600`	`604`	`(errcode_for_file_access(),`
`601`	`605`	`errmsg("could not stat file \"%s\": %m",path)));`
	`606`	`+}`
`602`	`607`
`603`	`608`	`/* Ignore anything but regular files */`
`604`	`609`	`if (!S_ISREG(attrib.st_mode))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitee40e89

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/genfile.c`

0 commit comments