NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitee3fdb8

Amit Kapila

committed

Improve RelationGetIdentityKeyBitmap().

We were using RelationGetIndexList() to update the relation's replicaidentity index but instead, we can directly use RelationGetReplicaIndex()which uses the same functionality. This is a minor code readabilityimprovement.Author: Japin LiReviewed-By: Takamichi Osumi, Amit KapilaDiscussion:https://postgr.es/m/4C99A862-69C8-431F-960A-81B1151F1B89@enterprisedb.com

1 parentb786304 commitee3fdb8Copy full SHA for ee3fdb8

File tree

1 file changed

-9

lines changed

src/backend/utils/cache
- relcache.c

1 file changed

-9

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 4 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -5244,9 +5244,9 @@ Bitmapset *`
`5244`	`5244`	`RelationGetIdentityKeyBitmap(Relationrelation)`
`5245`	`5245`	`{`
`5246`	`5246`	`Bitmapsetidindexattrs=NULL;/ columns in the replica identity */`
`5247`		`-List*indexoidlist;`
`5248`	`5247`	`RelationindexDesc;`
`5249`	`5248`	`inti;`
	`5249`	`+Oidreplidindex;`
`5250`	`5250`	`MemoryContextoldcxt;`
`5251`	`5251`
`5252`	`5252`	`/* Quick exit if we already computed the result */`
`@@ -5260,18 +5260,14 @@ RelationGetIdentityKeyBitmap(Relation relation)`
`5260`	`5260`	`/* Historic snapshot must be set. */`
`5261`	`5261`	`Assert(HistoricSnapshotActive());`
`5262`	`5262`
`5263`		`-indexoidlist=RelationGetIndexList(relation);`
`5264`		`-`
`5265`		`-/* Fall out if no indexes (but relhasindex was set) */`
`5266`		`-if (indexoidlist==NIL)`
`5267`		`-returnNULL;`
	`5263`	`+replidindex=RelationGetReplicaIndex(relation);`
`5268`	`5264`
`5269`	`5265`	`/* Fall out if there is no replica identity index */`
`5270`		`-if (!OidIsValid(relation->rd_replidindex))`
	`5266`	`+if (!OidIsValid(replidindex))`
`5271`	`5267`	`returnNULL;`
`5272`	`5268`
`5273`	`5269`	`/* Look up the description for the replica identity index */`
`5274`		`-indexDesc=RelationIdGetRelation(relation->rd_replidindex);`
	`5270`	`+indexDesc=RelationIdGetRelation(replidindex);`
`5275`	`5271`
`5276`	`5272`	`if (!RelationIsValid(indexDesc))`
`5277`	`5273`	`elog(ERROR,"could not open relation with OID %u",`
`@@ -5295,7 +5291,6 @@ RelationGetIdentityKeyBitmap(Relation relation)`
`5295`	`5291`	`}`
`5296`	`5292`
`5297`	`5293`	`RelationClose(indexDesc);`
`5298`		`-list_free(indexoidlist);`
`5299`	`5294`
`5300`	`5295`	`/* Don't leak the old values of these bitmaps, if any */`
`5301`	`5296`	`bms_free(relation->rd_idattr);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitee3fdb8

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/relcache.c`

0 commit comments