Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitee3ef4a

Browse files
committed
Improve comment of DeallocateStmt->isall
This field is not used directly in the code, but it is important forquery jumbling to be able to make a difference between a namedDEALLOCATE and DEALLOCATE ALL (seebb45156). This behavior istracked in the regression tests of pg_stat_statements, but the reasonwhy this field is important can be easily missed, as a recent discussionhas proved, so let's improve its comment to document the reason why itneeds to be around.Wording has been suggested by Tom LaneDiscussion:https://postgr.es/m/Zih1ATt37YFda8_p@paquier.xyz
1 parente51c2a4 commitee3ef4a

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

‎src/include/nodes/parsenodes.h

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4070,7 +4070,12 @@ typedef struct DeallocateStmt
40704070
NodeTagtype;
40714071
/* The name of the plan to remove, NULL if DEALLOCATE ALL */
40724072
char*namepg_node_attr(query_jumble_ignore);
4073-
/* true if DEALLOCATE ALL */
4073+
4074+
/*
4075+
* True if DEALLOCATE ALL. This is redundant with "name == NULL", but we
4076+
* make it a separate field so that exactly this condition (and not the
4077+
* precise name) will be accounted for in query jumbling.
4078+
*/
40744079
boolisall;
40754080
/* token location, or -1 if unknown */
40764081
ParseLoclocationpg_node_attr(query_jumble_location);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp