NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitee1b38f

Amit Kapila

committed

Fix memory leak in SnapBuildSerialize.

The memory for the snapshot was leaked while serializing it to disk duringlogical decoding. This memory will be freed only once walsender stopsstreaming the changes. This can lead to a huge memory increase when masterlogs Standby Snapshot too frequently say when the user is trying to createmany replication slots.Reported-by: funnyxj.fxj@alibaba-inc.comDiagnosed-by: funnyxj.fxj@alibaba-inc.comAuthor: Amit KapilaBackpatch-through: 9.5Discussion:https://postgr.es/m/033ab54c-6393-42ee-8ec9-2b399b5d8cde.funnyxj.fxj@alibaba-inc.com

1 parentbea449c commitee1b38fCopy full SHA for ee1b38f

File tree

1 file changed

-1

lines changed

src/backend/replication/logical
- snapbuild.c

1 file changed

-1

lines changed

`‎src/backend/replication/logical/snapbuild.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1488,7 +1488,7 @@ static void`
`1488`	`1488`	`SnapBuildSerialize(SnapBuild*builder,XLogRecPtrlsn)`
`1489`	`1489`	`{`
`1490`	`1490`	`Sizeneeded_length;`
`1491`		`-SnapBuildOnDisk*ondisk;`
	`1491`	`+SnapBuildOnDisk*ondisk=NULL;`
`1492`	`1492`	`char*ondisk_c;`
`1493`	`1493`	`intfd;`
`1494`	`1494`	`chartmppath[MAXPGPATH];`
`@@ -1687,6 +1687,9 @@ SnapBuildSerialize(SnapBuild *builder, XLogRecPtr lsn)`
`1687`	`1687`	`out:`
`1688`	`1688`	`ReorderBufferSetRestartPoint(builder->reorder,`
`1689`	`1689`	`builder->last_serialized_snapshot);`
	`1690`	`+/* be tidy */`
	`1691`	`+if (ondisk)`
	`1692`	`+pfree(ondisk);`
`1690`	`1693`	`}`
`1691`	`1694`
`1692`	`1695`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitee1b38f

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/snapbuild.c`

0 commit comments