NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitedfca4b

committed

Subject: Bug in SQLForeignKeys()

Query used for checking foreign key triggersreturns too many results when there're more than one foreignkey in a table. It happens because only table's oid is used tolink between pg_trigger with INSERT check and pg_trigger withUPDATE/DELETE check.I think there should be enough to add following conditionsinto WHERE clause of that query: AND pt.tgconstrname = pg_trigger.tgconstrname AND pt.tgconstrname = pg_trigger_1.tgconstrname/Constantin

1 parent3de8407 commitedfca4bCopy full SHA for edfca4b

File tree

2 files changed

-2

lines changed

src/interfaces/odbc
- info.c
- pgtypes.c

2 files changed

-2

lines changed

`‎src/interfaces/odbc/info.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2368,7 +2368,9 @@ Int2 result_cols;`
`2368`	`2368`	`"AND (pg_proc.proname LIKE '%%upd') "`
`2369`	`2369`	`"AND (pg_proc_1.proname LIKE '%%del') "`
`2370`	`2370`	`"AND (pg_trigger.tgrelid=pt.tgconstrrelid) "`
`2371`		`-"AND (pg_trigger_1.tgrelid = pt.tgconstrrelid))",`
	`2371`	`+"AND (pg_trigger.tgconstrname=pt.tgconstrname) "`
	`2372`	`+"AND (pg_trigger_1.tgrelid=pt.tgconstrrelid) "`
	`2373`	`+"AND (pg_trigger_1.tgconstrname=pt.tgconstrname))",`
`2372`	`2374`	`fk_table_needed);`
`2373`	`2375`
`2374`	`2376`	`result=SQLExecDirect(htbl_stmt,tables_query,strlen(tables_query));`

`‎src/interfaces/odbc/pgtypes.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,9 @@ Int2 pgtype_to_sqltype(StatementClass *stmt, Int4 type)`
`217`	`217`	`casePG_TYPE_XID:`
`218`	`218`	`casePG_TYPE_INT4:returnSQL_INTEGER;`
`219`	`219`
`220`		`-casePG_TYPE_INT8:returnSQL_BIGINT;`
	`220`	`+/* Change this to SQL_BIGINT for ODBC v3 bjm 2001-01-23 */`
	`221`	`+casePG_TYPE_INT8:returnSQL_CHAR;`
	`222`	`+`
`221`	`223`	`casePG_TYPE_NUMERIC:returnSQL_NUMERIC;`
`222`	`224`
`223`	`225`	`casePG_TYPE_FLOAT4:returnSQL_REAL;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitedfca4b

File tree

2 files changed

2 files changed

`‎src/interfaces/odbc/info.c`

`‎src/interfaces/odbc/pgtypes.c`

0 commit comments