NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitedda32e

committed

Fix compiler warning

Rewrite get_attgenerated() to avoid compiler warning if the compilerdoes not recognize that elog(ERROR) does not return.Reported-by: David Rowley <david.rowley@2ndquadrant.com>

1 parent82150a0 commitedda32eCopy full SHA for edda32e

File tree

1 file changed

-10

lines changed

src/backend/utils/cache
- lsyscache.c

1 file changed

-10

lines changed

`‎src/backend/utils/cache/lsyscache.c`

Lines changed: 7 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -836,22 +836,19 @@ char`
`836`	`836`	`get_attgenerated(Oidrelid,AttrNumberattnum)`
`837`	`837`	`{`
`838`	`838`	`HeapTupletp;`
	`839`	`+Form_pg_attributeatt_tup;`
	`840`	`+charresult;`
`839`	`841`
`840`	`842`	`tp=SearchSysCache2(ATTNUM,`
`841`	`843`	`ObjectIdGetDatum(relid),`
`842`	`844`	`Int16GetDatum(attnum));`
`843`		`-if (HeapTupleIsValid(tp))`
`844`		`-{`
`845`		`-Form_pg_attributeatt_tup= (Form_pg_attribute)GETSTRUCT(tp);`
`846`		`-charresult;`
`847`		`-`
`848`		`-result=att_tup->attgenerated;`
`849`		`-ReleaseSysCache(tp);`
`850`		`-returnresult;`
`851`		`-}`
`852`		`-else`
	`845`	`+if (!HeapTupleIsValid(tp))`
`853`	`846`	`elog(ERROR,"cache lookup failed for attribute %d of relation %u",`
`854`	`847`	`attnum,relid);`
	`848`	`+att_tup= (Form_pg_attribute)GETSTRUCT(tp);`
	`849`	`+result=att_tup->attgenerated;`
	`850`	`+ReleaseSysCache(tp);`
	`851`	`+returnresult;`
`855`	`852`	`}`
`856`	`853`
`857`	`854`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitedda32e

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/lsyscache.c`

0 commit comments