NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commited93feb

committed

Change currtid functions to use an MVCC snapshot, not SnapshotNow.

This has a slight performance cost, but the only known consumersof these functions, known at the SQL level as currtid and currtid2,is pgsql-odbc; whose usage, we hope, is not sufficiently intensiveto make this a problem.Per discussion.

1 parent80c79ab commited93febCopy full SHA for ed93feb

File tree

1 file changed

+10

-2

lines changed

src/backend/utils/adt
- tid.c

1 file changed

+10

-2

lines changed

`‎src/backend/utils/adt/tid.c`

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@`
`30`	`30`	`#include"utils/acl.h"`
`31`	`31`	`#include"utils/builtins.h"`
`32`	`32`	`#include"utils/rel.h"`
	`33`	`+#include"utils/snapmgr.h"`
`33`	`34`	`#include"utils/tqual.h"`
`34`	`35`
`35`	`36`
`@@ -332,6 +333,7 @@ currtid_byreloid(PG_FUNCTION_ARGS)`
`332`	`333`	`ItemPointerresult;`
`333`	`334`	`Relationrel;`
`334`	`335`	`AclResultaclresult;`
	`336`	`+Snapshotsnapshot;`
`335`	`337`
`336`	`338`	`result= (ItemPointer)palloc(sizeof(ItemPointerData));`
`337`	`339`	`if (!reloid)`
`@@ -352,7 +354,10 @@ currtid_byreloid(PG_FUNCTION_ARGS)`
`352`	`354`	`returncurrtid_for_view(rel,tid);`
`353`	`355`
`354`	`356`	`ItemPointerCopy(tid,result);`
`355`		`-heap_get_latest_tid(rel,SnapshotNow,result);`
	`357`	`+`
	`358`	`+snapshot=RegisterSnapshot(GetLatestSnapshot());`
	`359`	`+heap_get_latest_tid(rel,snapshot,result);`
	`360`	`+UnregisterSnapshot(snapshot);`
`356`	`361`
`357`	`362`	`heap_close(rel,AccessShareLock);`
`358`	`363`
`@@ -368,6 +373,7 @@ currtid_byrelname(PG_FUNCTION_ARGS)`
`368`	`373`	`RangeVar*relrv;`
`369`	`374`	`Relationrel;`
`370`	`375`	`AclResultaclresult;`
	`376`	`+Snapshotsnapshot;`
`371`	`377`
`372`	`378`	`relrv=makeRangeVarFromNameList(textToQualifiedNameList(relname));`
`373`	`379`	`rel=heap_openrv(relrv,AccessShareLock);`
`@@ -384,7 +390,9 @@ currtid_byrelname(PG_FUNCTION_ARGS)`
`384`	`390`	`result= (ItemPointer)palloc(sizeof(ItemPointerData));`
`385`	`391`	`ItemPointerCopy(tid,result);`
`386`	`392`
`387`		`-heap_get_latest_tid(rel,SnapshotNow,result);`
	`393`	`+snapshot=RegisterSnapshot(GetLatestSnapshot());`
	`394`	`+heap_get_latest_tid(rel,snapshot,result);`
	`395`	`+UnregisterSnapshot(snapshot);`
`388`	`396`
`389`	`397`	`heap_close(rel,AccessShareLock);`
`390`	`398`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commited93feb

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/tid.c`

0 commit comments