Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commited9247c

Browse files
committed
Fix briefly showing old progress stats for ANALYZE on inherited tables.
ANALYZE on a table with inheritance children analyzes all the childtables in a loop. When stepping to next child table, it updated thechild rel ID value in the command progress stats, but did not resetthe 'sample_blks_total' and 'sample_blks_scanned' counters.acquire_sample_rows() updates 'sample_blks_total' as soon as the scanstarts and 'sample_blks_scanned' after processing the first block, butuntil then, pg_stat_progress_analyze would display a bogus combinationof the new child table relid with old counter values from thepreviously processed child table. Fix by resetting 'sample_blks_total'and 'sample_blks_scanned' to zero at the same time that'current_child_table_relid' is updated.Backpatch to v13, where pg_stat_progress_analyze view was introduced.Reported-by: Justin PryzbyDiscussion:https://www.postgresql.org/message-id/20230122162345.GP13860%40telsasoft.com
1 parent6875bac commited9247c

File tree

1 file changed

+19
-2
lines changed

1 file changed

+19
-2
lines changed

‎src/backend/commands/analyze.c

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1384,8 +1384,25 @@ acquire_inherited_sample_rows(Relation onerel, int elevel,
13841384
AcquireSampleRowsFuncacquirefunc=acquirefuncs[i];
13851385
doublechildblocks=relblocks[i];
13861386

1387-
pgstat_progress_update_param(PROGRESS_ANALYZE_CURRENT_CHILD_TABLE_RELID,
1388-
RelationGetRelid(childrel));
1387+
/*
1388+
* Report progress. The sampling function will normally report blocks
1389+
* done/total, but we need to reset them to 0 here, so that they don't
1390+
* show an old value until that.
1391+
*/
1392+
{
1393+
constintprogress_index[]= {
1394+
PROGRESS_ANALYZE_CURRENT_CHILD_TABLE_RELID,
1395+
PROGRESS_ANALYZE_BLOCKS_DONE,
1396+
PROGRESS_ANALYZE_BLOCKS_TOTAL
1397+
};
1398+
constint64progress_vals[]= {
1399+
RelationGetRelid(childrel),
1400+
0,
1401+
0,
1402+
};
1403+
1404+
pgstat_progress_update_multi_param(3,progress_index,progress_vals);
1405+
}
13891406

13901407
if (childblocks>0)
13911408
{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp