NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commited7eff8

committed

Guard against using plperl's Makefile without specifying --with-perl.

The $(PERL) macro will be set by configure if it finds perl at all,but $(perl_privlibexp) isn't configured unless you said --with-perl.This results in confusing error messages if someone cd's intosrc/pl/plperl and tries to build there despite the configure omission,as reported by Tomas Vondra in bug #6198. Add simple checks toprovide a more useful report, while not disabling other use of themakefile such as "make clean".Back-patch to 9.0, which is as far as the patch applies easily.

1 parent0962182 commited7eff8Copy full SHA for ed7eff8

File tree

1 file changed

-1

lines changed

src/pl/plperl
- GNUmakefile

1 file changed

-1

lines changed

`‎src/pl/plperl/GNUmakefile`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -57,17 +57,21 @@ include $(top_srcdir)/src/Makefile.shlib`
`57`	`57`	`plperl.o: perlchunks.h plperl_opmask.h`
`58`	`58`
`59`	`59`	`plperl_opmask.h: plperl_opmask.pl`
	`60`	`+@if [ x"$(perl_privlibexp)"= x"" ];thenecho"configure switch --with-perl was not specified.";exit 1;fi`
`60`	`61`	`$(PERL)$<$@`
`61`	`62`
`62`		`-perlchunks.h:$(PERLCHUNKS)`
	`63`	`+perlchunks.h:$(PERLCHUNKS)`
	`64`	`+@if [ x"$(perl_privlibexp)"= x"" ];thenecho"configure switch --with-perl was not specified.";exit 1;fi`
`63`	`65`	`$(PERL)$(srcdir)/text2macro.pl --strip='^(\#.\|\s)$$'$^>$@`
`64`	`66`
`65`	`67`	`all: all-lib`
`66`	`68`
`67`	`69`	`SPI.c: SPI.xs`
	`70`	`+@if [ x"$(perl_privlibexp)"= x"" ];thenecho"configure switch --with-perl was not specified.";exit 1;fi`
`68`	`71`	`$(PERL)$(perl_privlibexp)/ExtUtils/xsubpp -typemap$(perl_privlibexp)/ExtUtils/typemap$<>$@`
`69`	`72`
`70`	`73`	`Util.c: Util.xs`
	`74`	`+@if [ x"$(perl_privlibexp)"= x"" ];thenecho"configure switch --with-perl was not specified.";exit 1;fi`
`71`	`75`	`$(PERL)$(perl_privlibexp)/ExtUtils/xsubpp -typemap$(perl_privlibexp)/ExtUtils/typemap$<>$@`
`72`	`76`
`73`	`77`	`install: all installdirs install-lib`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commited7eff8

File tree

1 file changed

1 file changed

`‎src/pl/plperl/GNUmakefile`

0 commit comments